Merge lp:~xnox/utah/wubi-still-exists into lp:utah

[Dimitri John Ledkov]

Initially, raring images did not have wubi (it was not build for
raring yet). But wubi is now present on raring images and should be
tested for. Maybe this static check can be moved to a separate jenkins
job, such that WUBI fail, does not block all other downstream tests.

[Javier Collado (javier.collado)]

Thanks for the changes. I've verified with today's distro for i386 and amd64
and it worked fine.

The idea about moving to a different job tests that can fail for testable
images is good. I'll open a bug about that to follow up.

review: Approve

[Max Brustkern (nuclearbob)]

I agree with the idea of having separate analysis that does not block other jobs. The job blocking was the reason this test was altered in the first place. :)

review: Approve

[Javier Collado (javier.collado)]

The bug I opened to follow the conversation about which tests cases should
block smoke testing and which ones should not is: 1088444

=== modified file 'utah/isotest/iso_static_validation.py'
--- utah/isotest/iso_static_validation.py	2012-12-06 16:30:34 +0000
+++ utah/isotest/iso_static_validation.py	2012-12-08 02:20:25 +0000
@@ -262,9 +262,8 @@
 
     # Test if  wubi is present for desktop or dvd and it is a valid PE
     @unittest.skipUnless(st_variant == 'desktop' and
-                         st_arch != 'powerpc' and st_release < 'raring',
-                         "Skipping images that aren't ubiquity-based and "
-                         "older than raring")
+                         st_arch != 'powerpc',
+                         "Skipping images that aren't ubiquity-based.")
     def test_wubi(self):
         logging.debug('Extracting wubi from the desktop images')
         (stdout, stderr) = self.iso.extract('./wubi.exe', self.temp_dir)