Code review comment for lp:~xnox/upstart/shrink-notifications

Revision history for this message
James Hunt (jamesodhunt) wrote :

I don't understand the change you've made to job_process_handler():

=== modified file 'init/job_process.c'
--- init/job_process.c 2014-07-08 14:11:53 +0000
+++ init/job_process.c 2014-07-10 07:54:25 +0000
@@ -1474,6 +1474,11 @@
        job = job_process_find (pid, &process);
        if (! job)
                return;
+
+ /* Child setup process died, before finishing the setup.
+ */
+ if (job->process_data[process] && job->process_data[process]->valid)
+ return;

This seems to be what is causing the branch to fail to boot too.

« Back to merge proposal