Code review comment for lp:~xnox/upstart/shrink-notifications

> Still racy I'm afraid:
>
> not ok 48 - with single-line command running an invalid command, then a 1-line
> post-stop script
> wrong value for child_exit_status[1], expected 255 got 0
> at tests/test_job_process.c:3193 (test_start).
> Aborted (core dumped)
> ERROR: failed on iteration 6
>
> #2 0x0000000000428c92 in test_start () at tests/test_job_process.c:3193
> 3193 TEST_EQ (child_exit_status[1], 255);
> (gdb) p child_exit_status[1]
> $1 = 0
> (gdb)

It is better than it was before.

What about review of the actual code changes? Do you approve those?