Merge lp:~xnox/upstart/fix-1235649 into lp:upstart

Proposed by Dimitri John Ledkov on 2013-10-08
Status: Rejected
Rejected by: Dimitri John Ledkov on 2013-11-03
Proposed branch: lp:~xnox/upstart/fix-1235649
Merge into: lp:upstart
Diff against target: 18 lines (+8/-0)
1 file modified
extra/upstart-udev-bridge.c (+8/-0)
To merge this branch: bzr merge lp:~xnox/upstart/fix-1235649
Reviewer Review Type Date Requested Status
James Hunt 2013-10-08 Disapprove on 2013-10-08
Review via email: mp+189860@code.launchpad.net

Description of the change

workaround #1
blacklist SPAM event in upstart-udev-bridge, thus not emitting system event nor re-emitting it to session-init.

this still leaves systemd-udev to consume 5% CPU constantly when the screen is on.

Will work on a systemd-udev patch.

To post a comment you must log in.
James Hunt (jamesodhunt) wrote :

- Formatting is not standard: missing space after function name and before bracket. Aslo, why brackets round 'action' and 'kernel'?
- This is an ubuntu-specific work-around so should only be applied to Ubuntu if absolutely necessary.

review: Disapprove

Unmerged revisions

1544. By Dimitri John Ledkov on 2013-10-08

Ignore VSYNC events from omapfb, as not needed and cause spam when re-emitted to session init.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extra/upstart-udev-bridge.c'
2--- extra/upstart-udev-bridge.c 2011-12-15 16:14:06 +0000
3+++ extra/upstart-udev-bridge.c 2013-10-08 14:14:17 +0000
4@@ -228,6 +228,14 @@
5 if (! action)
6 goto out;
7
8+ /* Ignore spam http://pad.lv/1235649 */
9+ if (
10+ (action) && (kernel) && (subsystem) &&
11+ (strcmp(action, "change") == 0) &&
12+ (strcmp(kernel, "omapfb") == 0) &&
13+ (strcmp(subsystem, "platform") == 0))
14+ goto out;
15+
16 if (! strcmp (action, "add")) {
17 name = NIH_MUST (nih_sprintf (NULL, "%s-device-added",
18 subsystem));

Subscribers

People subscribed via source and target branches