Code review comment for lp:~xnox/unity8/cross-compile

On 13 December 2013 09:45, Michał Sawicz <email address hidden> wrote:
> On 13.12.2013 10:12, Dimitri John Ledkov wrote:
>> Please do not commit auto-generated code to VCS. All other upstreams /
>> packages in the archive, generate dbus code at compile time,
>> regardless if it's native or cross. Why commit a static version, when
>> it can always be generated afresh?
>
> http://qt-project.org/doc/qt-5.0/qtdbus/qdbusxml2cpp.html
>
> "The qdbusxml2cpp tool is not meant to be run every time you compile
> your application. Instead, it's meant to be used when developing the
> code or when the interface changes."
>

it does make sense to ship pre-generated dbus code in, e.g. release
tarball, but not in the version control system. And that dbus tool, is
not that different from all the other dbus implementations - e.g.
upstream (libdbus), gnome/gio dbus, libnih-dbus, etc. Also as per
debian policy, generated source code must be re-generated at
build-time which is applied consistently for all dbus, cython, vala,
etc. generators.

> I'm leaning towards that just because it makes sense, that generated
> file will barely ever change (as long as the source file doesn't
> change). OTOH building against different versions of Qt, in this case,
> might yield different results for the generated files...
>

For QA and CI it's a slippery slope to forget regenerating static
copies. Or not catch that one cannot regenerate it anymore.

--
Regards,

Dimitri.