Code review comment for lp:~xnox/unity8/cross-compile

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

On 13.12.2013 10:12, Dimitri John Ledkov wrote:
> Please do not commit auto-generated code to VCS. All other upstreams /
> packages in the archive, generate dbus code at compile time,
> regardless if it's native or cross. Why commit a static version, when
> it can always be generated afresh?

http://qt-project.org/doc/qt-5.0/qtdbus/qdbusxml2cpp.html

"The qdbusxml2cpp tool is not meant to be run every time you compile
your application. Instead, it's meant to be used when developing the
code or when the interface changes."

I'm leaning towards that just because it makes sense, that generated
file will barely ever change (as long as the source file doesn't
change). OTOH building against different versions of Qt, in this case,
might yield different results for the generated files...

« Back to merge proposal