Code review comment for lp:~xnox/unity-greeter/no-s390x

Revision history for this message
Iain Lane (laney) wrote :

On Fri, Dec 09, 2016 at 01:21:59PM +0000, Iain Lane wrote:
> On Fri, Dec 09, 2016 at 01:13:29PM -0000, Dimitri John Ledkov wrote:
> > Dimitri John Ledkov has proposed merging lp:~xnox/unity-greeter/no-s390x into lp:unity-greeter.
> >
> > Requested reviews:
> > Unity Greeter Development Team (unity-greeter-team)
> >
> > For more details, see:
> > https://code.launchpad.net/~xnox/unity-greeter/no-s390x/+merge/312912
> >
> > Do not re-introduce s390x builds now that upstart b-d is now removed.
>
> I thought that the only problem was that we built uninstallable packages
> due to Depends: upstart. Without that, the s390x packages would be
> installable and so there's no problem building them.
>
> Is that right?

Indeed:

  https://code.launchpad.net/~laney/unity-greeter/bd-upstart/+merge/303386/comments/801401

So IMO it's okay to just drop both the BD and the D.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

« Back to merge proposal