Merge lp:~xnox/ubuntu/wily/upstart/lp1447099 into lp:ubuntu/wily/upstart

Proposed by Dimitri John Ledkov
Status: Merged
Merge reported by: Dimitri John Ledkov
Merged at revision: not available
Proposed branch: lp:~xnox/ubuntu/wily/upstart/lp1447099
Merge into: lp:ubuntu/wily/upstart
Diff against target: 30 lines (+9/-0)
2 files modified
debian/changelog (+4/-0)
extra/conf-session/upstart-event-bridge.conf (+5/-0)
To merge this branch: bzr merge lp:~xnox/ubuntu/wily/upstart/lp1447099
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+259319@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Hunt (jamesodhunt) wrote :

Hi Dimitri,

Thanks for fixing this. Please could you simplify the test though - I think it's much clearer to avoid the "double-negative" and just write:

    test -d /run/systemd/system && { stop; exit 0; }

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-04-25 18:06:30 +0000
3+++ debian/changelog 2015-05-16 19:44:02 +0000
4@@ -1,8 +1,12 @@
5 upstart (1.13.2-0ubuntu14) UNRELEASED; urgency=medium
6
7+ [ James Hunt ]
8 * Cherry-pick upstream fix for LP: #1447756, fixing broken handling
9 when flushing logs to disk.
10
11+ [ Dimitri John Ledkov ]
12+ * Do not start upstart-event-bridge, if pid1 is systemd. (LP: #1447099)
13+
14 -- James Hunt <james.hunt@ubuntu.com> Fri, 24 Apr 2015 13:59:00 +0100
15
16 upstart (1.13.2-0ubuntu13) vivid; urgency=medium
17
18=== modified file 'extra/conf-session/upstart-event-bridge.conf'
19--- extra/conf-session/upstart-event-bridge.conf 2013-07-18 14:12:13 +0000
20+++ extra/conf-session/upstart-event-bridge.conf 2015-05-16 19:44:02 +0000
21@@ -12,4 +12,9 @@
22
23 respawn
24
25+# Do not start, if pid1 is systemd LP: #1447099
26+pre-start script
27+ test ! -d /run/systemd/system || { stop; exit 0; }
28+end script
29+
30 exec upstart-event-bridge

Subscribers

People subscribed via source and target branches