Merge lp:~xnox/ubuntu/vivid/nuntium/drop-sys-events into lp:ubuntu/vivid/nuntium

[Dimitri John Ledkov]

Migrate from :sys:started events to dbus owner signals.

Migrate from :sys:started events to dbus owner signals.

[Dimitri John Ledkov (xnox)]

When system upstart goes away, :sys:started/stopped/starting/stopping events will go away.

One option is to introduce a user session event bridge which will relay similar events from systemd. I have a working prototype for that, however incomplete information is exposed by systemd at the moment.

Another option is to key onto approximately equivalent events which are already available.

This is a master bug to track all users and port them.

[Sebastien Bacher (seb128)]

could somebody review that change?

[Dimitri John Ledkov (xnox)]

dunno, let me try my colleague james...

[James Hunt (jamesodhunt)]

I can't test this, but looks good in principle.

[Martin Pitt (pitti)]

I haven't tested this either, how can this be done? "I get a bubble for receiving an SMS", or is it only an MMS as the package description says?

But it looks good indeed.

[Iain Lane (laney)]

Shouldn't this be on lp:nuntium? Can you re-file it there?

What does "''" mean? Empty string or wildcard?

review: Resubmit

[Dimitri John Ledkov (xnox)]

@Laney and what is https://code.launchpad.net/~xnox/nuntium/drop-sys-events/+merge/246049 ?

Please merge this already........ somehow..... it's been 8 months now.

Note that the "dbus" even is the same in both start on and stop condition. The difference between them are the ARG1/ARG2, when a name is acquired it goes from empty -> something rather (unique dbus object name); when lost the even goes from something rather -> empty.

Hence the ARG1='' ARG2='*' for start; and ARG1='*' ARG2='' for stop.

[Iain Lane (laney)]

On Wed, Sep 02, 2015 at 10:11:47AM -0000, Dimitri John Ledkov wrote:
> @Laney and what is https://code.launchpad.net/~xnox/nuntium/drop-sys-events/+merge/246049 ?
>
> Please merge this already........ somehow..... it's been 8 months now.

Thanks :)

I asked abeato if he would review that.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Iain Lane (laney)]

https://code.launchpad.net/~alfonsosanchezbeato/nuntium/drop-sys-events/+merge/269901

Done!

Unmerged revisions

19. By Dimitri John Ledkov on 2015-01-11

Migrate from :sys:started events to dbus owner signals. (LP:
#1409356)

=== modified file 'debian/changelog'
--- debian/changelog	2014-11-07 16:01:53 +0000
+++ debian/changelog	2015-01-11 00:50:14 +0000
@@ -1,3 +1,10 @@
+nuntium (1.1-0ubuntu2) UNRELEASED; urgency=medium
+
+  * Migrate from :sys:started events to dbus owner signals. (LP:
+    #1409356)
+
+ -- Dimitri John Ledkov <[e-mail]>  Sun, 11 Jan 2015 00:49:17 +0000
+
 nuntium (1.1-0ubuntu1) vivid; urgency=medium
 
   * Minor tree refactor.

=== modified file 'debian/nuntium.conf'
--- debian/nuntium.conf	2014-05-14 14:21:59 +0000
+++ debian/nuntium.conf	2015-01-11 00:50:14 +0000
@@ -1,6 +1,10 @@
 description "nuntium service binds ofono and telepathy-ofono for MMS"
 
-start on (:sys:started JOB=ofono or started dbus)
-stop on :sys:stopping JOB=ofono
+# Start on session dbus is spawned or
+#     org.ofono bus name appears on system dbus
+# Stop on org.ofono bus name disappearing on system dbus
+
+start on (started dbus or dbus SIGNAL='NameOwnerChanged' BUS='system' INTERFACE='org.freedesktop.DBus' OBJPATH='/org/freedesktop/DBus' SENDER='org.freedesktop.DBus' ARG0='org.ofono' ARG1='' ARG2='*')
+stop on dbus SIGNAL='NameOwnerChanged' BUS='system' INTERFACE='org.freedesktop.DBus' OBJPATH='/org/freedesktop/DBus' SENDER='org.freedesktop.DBus' ARG0='org.ofono' ARG1='*' ARG2=''
 
 exec nuntium