Code review comment for lp:~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Apart from "didn't work" comment no other comments were provided neither at
the time, not now. Fully works here for me. What's wrong?
On 12 Aug 2014 15:41, "David Planella" <email address hidden> wrote:

> Review: Disapprove
>
> Rejected as part of cleaning up MPs for Terminal. We discussed the changes
> on this branch a while ago (I can't find the comments, though), and the
> issue is that replacing the Python import without replacing the code that
> processes the XML won't work.
> --
>
> https://code.launchpad.net/~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3/+merge/218483
> You are the owner of lp:~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3.
>

« Back to merge proposal