Code review comment for lp:~xnox/ubuntu-terminal-app/drop-lxml-dep
Revision history for this message
| Dimitri John Ledkov (xnox) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
On 6 May 2014 19:46, David Planella <email address hidden> wrote:
> Review: Needs Fixing
>
> Note that it's not a matter of just replacing the import, as it seems that the standard module is not a drop-in replacement for lxml.
>
> So further code changes will be required in CMakePluginPars
>
> In any case, as discussed on IRC with balloons, I'll split the original MP to isolate this change and not block on it.
Yeah, well i've run the tests on the desktop and they all passed....
not sure if CMakePluginParser was actually in fact used or not.
--
Regards,
Dimitri.