Merge lp:~xnox/ubuntu-seeds/drop-python2.ubuntu-touch.trusty into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.trusty

Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Oliver Grawert
Proposed branch: lp:~xnox/ubuntu-seeds/drop-python2.ubuntu-touch.trusty
Merge into: lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.trusty
Diff against target: 10 lines (+0/-1)
1 file modified
touch (+0/-1)
To merge this branch: bzr merge lp:~xnox/ubuntu-seeds/drop-python2.ubuntu-touch.trusty
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+207811@code.launchpad.net

Commit message

Drop ofono-scripts, because they are written in python2. Also, even if
ported to python3 they should not be present in the default install.

Description of the change

Drop ofono-scripts, because they are written in python2. Also, even if
ported to python3 they should not be present in the default install.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Ack, they are mostly needed for testing, but ofono-phonesim-autostart already depends on ofono-scripts.

review: Approve
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 25 February 2014 11:16, Martin Pitt <email address hidden> wrote:
> Review: Approve
>
> Ack, they are mostly needed for testing, but ofono-phonesim-autostart already depends on ofono-scripts.
>

Well, we are also trying to port scripts to python3. Let me linkup
that merge proposal to the bug report.
--
Regards,

Dimitri.

Revision history for this message
Tony Espy (awe) wrote :

I'd prefer if these scripts weren't removed as default, as they're very useful for debugging ofono problems and I quite frequently ask people to use them when diagnosing telephony issues. Also, if we get the cycles they could also be valuable for ofono specific bug reporting.

Is there a mandate to remove all such tools from our images?

I've updated the original bug with an update re: Martin's Py3 changes which have been merged into github.

Revision history for this message
Oliver Grawert (ogra) wrote :

these scripts are essential for using phone features wehere we do not have a UI yet, i discussed several times with dimitri over the last days that they need to stay, i don't know why this MP was not put to rest after this discussion.

Unmerged revisions

152. By Dimitri John Ledkov

Drop ofono-scripts, because they are written in python2. Also, even if
ported to python3 they should not be present in the default install.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'touch'
2--- touch 2014-02-22 12:08:57 +0000
3+++ touch 2014-02-22 23:19:02 +0000
4@@ -129,7 +129,6 @@
5 * unity-scope-mediascanner
6 * unity-scope-video-remote
7 * url-dispatcher
8- * ofono-scripts
9
10 == Apps ==
11

Subscribers

People subscribed via source and target branches