Merge lp:~xnox/ubuntu-release-upgrader/eoan-kernel-sizes into lp:ubuntu-release-upgrader

Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Brian Murray
Proposed branch: lp:~xnox/ubuntu-release-upgrader/eoan-kernel-sizes
Merge into: lp:ubuntu-release-upgrader
Diff against target: 17 lines (+2/-2)
1 file modified
DistUpgrade/DistUpgradeCache.py (+2/-2)
To merge this branch: bzr merge lp:~xnox/ubuntu-release-upgrader/eoan-kernel-sizes
Reviewer Review Type Date Requested Status
Brian Murray Disapprove
Review via email: mp+374125@code.launchpad.net

Commit message

Update kernel/initrd size calculation fallbacks to be closer to eoan reality.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Should we get this into Focal now?

Revision history for this message
Brian Murray (brian-murray) wrote :

Or should the sizes be double checked?

Revision history for this message
Brian Murray (brian-murray) wrote :

My initrd on focal is almost 100M.

Revision history for this message
Brian Murray (brian-murray) wrote :

This wasn't merged for Eoan and u-r-u has now moved to git, so I'm rejecting this MP but will make the changes for Focal.

review: Disapprove

Unmerged revisions

3297. By Dimitri John Ledkov

Update kernel & initrd sizes fallbacks to match eoan.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DistUpgrade/DistUpgradeCache.py'
2--- DistUpgrade/DistUpgradeCache.py 2019-10-09 15:41:45 +0000
3+++ DistUpgrade/DistUpgradeCache.py 2019-10-15 09:46:43 +0000
4@@ -69,11 +69,11 @@
5 if kernel == 0:
6 logging.warning(
7 "estimate_kernel_initrd_size_in_boot() returned '0' for kernel?")
8- kernel = 28*1024*1024
9+ kernel = 16*1024*1024
10 if initrd == 0:
11 logging.warning(
12 "estimate_kernel_initrd_size_in_boot() returned '0' for initrd?")
13- initrd = 45*1024*1024
14+ initrd = 81*1024*1024
15 # add small safety buffer
16 kernel += 1*1024*1024
17 # safety buffer as a percentage of the existing initrd's size

Subscribers

People subscribed via source and target branches