Code review comment for lp:~xnox/ubuntu-cdimage/generic-preinstalled

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Hi,

On Wed, Jun 16, 2021 at 9:24 AM Łukasz Zemczak
<email address hidden> wrote:
>
> Review: Needs Information
>
> Ok, so even though this would indeed make the end images not have 'generic' in the name, I thought Steve wanted not to use SUBARCH at all for these preinstalled images? Since yeah, if it's just about the naming, we can go ahead.
>

In livecd-rootfs that is not possible. Livecd-rootfs is not using
ubuntu-server project at all, but ubuntu-cpc one. And ubuntu-cpc
without subarch are our cloud image builds which are very different to
what we call ubuntu-server preinstalled.

For example, we install full kernel rather than virtual; we bake in
cloud-init config and allow ubuntu:ubuntu login rather than requiring
datasource.

You will not be able to use subarchless ubuntu-cpc project in
livecd-rootfs to build preinstalled ubuntu-server images.

> Steve, was it only the naming you were interested in? Or in the way we build the images?
>

He naked the name as published by ubuntu-cdimage. I did not see a
request from him to change anything in livecd-rootfs, nor do I see a
way how it could be done. It is a matter of fact that ubuntu-cdimage
projects != livecd-rootfs projects. And we did that intentionally.

> That being said, I *personally* am not a big fan of such implicit transformations, so if it was about me I'd either stick with 'generic' in the name or revamp livecd-rootfs+cdimage to not use SUBARCH for building the preinstalled amd64/arm64 images (which was my original intention when taking the card). The whole livecd-rootfs and ubuntu-cdimage story is already confusing enough, requiring quirk knowledge (like, ubuntu-server preinstalled using ubuntu-cpc as the project etc.). Yet another hidden translation like this feels unnecessary.
>
> I have started working on a branch that would add such images using the 'new way' of preinstalled image building, so with IMAGEFORMAT=ubuntu-image. I'd like us to use ubuntu-image as much as possible as currently right now it's only used for the pi's.

I just want the images published, for which everything was ready
months ago. Are you going to have ubuntu-image based pre-installed
images ready by end of next week?

--
Regards,

Dimitri.

« Back to merge proposal