Merge lp:~xnox/ubuntu-archive-tools/sru-report-autopkgtest-vomit into lp:ubuntu-archive-tools

[Dimitri John Ledkov]

systemd triggered regressions make the report unreadable

[Dimitri John Ledkov (xnox)]

Newly generated sample page:

http://people.canonical.com/~xnox/pending-sru.html

[Łukasz Zemczak (sil2100)]

Just commenting on the visuals here:

It all seems like a decent idea but I think the visual side would still need some work. One thing I'd like to try is to make the build failures in the list smaller. It's quite frequent for some packages to have more than 4-5 failures listed, which suddenly makes it hard to read. Also, the table cells have varying size so the bigger and more ADT failures are listed, the smaller the other columns are - and for the SRU team both the bugs and ADT-result ones are equally important. Speaking of which, maybe we should work a bit on the formatting of the table columns. I'm not saying that previously everything was ok, but now with a new high-width column the tables for each series can potentially look completely different. Maybe we should standardize their sizes somehow?

[Dimitri John Ledkov (xnox)]

Please reject this merge proposal

review: Disapprove (obsolete)

Unmerged revisions

1167. By Dimitri John Ledkov on 2018-03-18

Autopkgtest regression in a standalone column

Currently autopkgtests regressions, make a vomit of a page, if there
are a lot of them. Move them to a separate column, to significantly
shorten the page, and make it easier to go through the autopkgtest
regressions.

This tries to group autopkgtest regressions under a package name, and
make arch tag link to the test log, whilst the regressed package links
to the overall table of tests for said package.

=== modified file 'sru-report'
--- sru-report	2017-10-28 17:29:35 +0000
+++ sru-report	2018-03-18 00:50:19 +0000
@@ -271,7 +271,8 @@
 <table id='%s'>
   <tr><th>Package</th><th>-release</th><th>-updates</th>
   <th>-proposed (signer, creator)</th>
-  <th>changelog bugs</th><th>days</th></tr>''' % (release, release))
+  <th>changelog bugs</th><th>Autopkgtest regressions</th>
+  <th>days</th></tr>''' % (release, release))
         for pkg, pub in sorted(pkg_index[release].iteritems(),
                                key=itemgetter(1)):
             # skip everything that shows up on the kernel SRU reports
@@ -296,15 +297,8 @@
             if builds:
                 builds = '<span style="font-size: x-small">%s</span>' % builds
 
-            autopkg_fails = ''
-            for excuse in rpkg['autopkg_fails']:
-                autopkg_fails += '<br/>%s' % excuse
-            if autopkg_fails:
-                autopkg_fails = '<span style="font-size: x-small">%s</span>' \
-                    % autopkg_fails
-
-            print('  <tr><td><a href="%s">%s</a>%s %s</td> ' %
-                  (pkgurl, pkg, builds, autopkg_fails))
+            print('  <tr><td><a href="%s">%s</a>%s</td> ' %
+                  (pkgurl, pkg, builds))
             print('  <td><a href="%s">%s</a></td> ' %
                   (pkgurl + rpkg['release'], rpkg['release']))
             print('  <td><a href="%s">%s</a></td> ' %
@@ -392,10 +386,12 @@
                       'title="%s" %s>%d%s</a>' %
                       (lp_url, b, hover_text.replace('"', ''), cls, b,
                        '(hw)' if 'hw-specific' in t else ''))
+
             if antique and removable:
                 proposed_antique.append((releases[release].name, pkg,
                                         [str(b) for b in rpkg['bugs']]))
             print('&nbsp;</td>')
+            print('  <td>%s</td>' % ' '.join(rpkg['autopkg_fails']))
             print('  <td>%i</td></tr>' % age)
         print('</table>')
 
@@ -677,6 +673,7 @@
                         if 'autopkgtest' not in excuse['policy_info']:
                             continue
                         for testpkg in excuse['policy_info']['autopkgtest']:
+                            autopkg_excuses = []
                             for arch in excuse['policy_info']['autopkgtest'][testpkg]:
                                 if excuse['policy_info']['autopkgtest'][testpkg][arch][0] == 'REGRESSION':
                                     link = excuse['policy_info']['autopkgtest'][testpkg][arch][1]
@@ -685,8 +682,10 @@
                                         testpkg_idx = testpkg_name[:3]
                                     else:
                                         testpkg_idx = testpkg_name[0]
-                                    autopkg_url = 'http://autopkgtest.ubuntu.com/packages/%s/%s/%s/%s' % (testpkg_idx, testpkg_name, release, arch)
-                                    srus[release][pkg]['autopkg_fails'].append('Regression in autopkgtest for <a href="%s">%s (%s)</a>: <a href="%s">test log</a>' % (autopkg_url, testpkg_name, arch, link))
+                                    autopkg_url = 'http://autopkgtest.ubuntu.com/packages/%s/%s' % (testpkg_idx, testpkg_name)
+                                    autopkg_excuses.append('<a href="%s">%s </a>' % (link, arch))
+                            if autopkg_excuses:
+                                srus[release][pkg]['autopkg_fails'].append('<a href="%s">%s</a> (%s)' % (autopkg_url, testpkg_name, ' '.join(autopkg_excuses)))
 
     return srus