Merge lp:~xnox/system-service/python3 into lp:system-service
Proposed by
Dimitri John Ledkov
Status: | Needs review |
---|---|
Proposed branch: | lp:~xnox/system-service/python3 |
Merge into: | lp:system-service |
Diff against target: |
197 lines (+31/-29) 8 files modified
UbuntuSystemService/backend.py (+7/-10) UbuntuSystemService/utils.py (+3/-3) backend/system-service-d (+4/-4) debian/changelog (+6/-0) debian/compat (+1/-1) debian/control (+7/-6) debian/rules (+1/-1) setup.py (+2/-4) |
To merge this branch: | bzr merge lp:~xnox/system-service/python3 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Pitt | Approve | ||
Michael Vogt | Pending | ||
Review via email: mp+192805@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 76. By Dimitri John Ledkov
-
Clean-up unused imports
- 75. By Dimitri John Ledkov
-
port system-service-d to python3.
- 74. By Dimitri John Ledkov
-
Port to python3.
LGTM, except this bit:
65 - print (model, layout, variant, options)
66 + print((model, layout, variant, options))
which I assume is an overzealous 2to3 artifact. I'll revert that, and otherwise upload. Thanks!