Code review comment for lp:~xnox/partman-auto/avoid-hung-blkid

On Wed, Dec 12, 2012 at 11:56:27AM -0000, Dmitrijs Ledkovs wrote:
> - [ "$fs" != free ] || continue
> + [ ! $(echo "$fs" | grep -s -e free -e fat -e ntfs -e hfs+ -e linux-swap) ] || continue

This is dangerously underquoted around the $(...), and I think I would
suggest using egrep -s 'foo|bar|baz' rather than grep -s -e foo -e bar
-e baz ... it's just a bit more standard in d-i code. (And, in that
case, be careful to escape the + in hfs+.)

> + - Skip mounting filesystems that ought to not be Ubuntu root
> + filesystems (empty, swap, fat, ntfs, hfs). This also should speed up
> + automatic partitioning page.

hfs and hfs+ are different filesystems, and at the moment you only
exclude hfs+.

Any reason not to exclude hfs and hfsx as well?