Merge ~xnox/network-manager:ubuntu/master into network-manager:ubuntu/master

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: fbe61ddadf4a89800a8e3651ae91099259ddf2ad
Proposed branch: ~xnox/network-manager:ubuntu/master
Merge into: network-manager:ubuntu/master
Diff against target: 35 lines (+8/-1)
2 files modified
debian/changelog (+6/-0)
debian/tests/network_test_base.py (+2/-1)
Reviewer Review Type Date Requested Status
Network-manager Pending
Review via email: mp+411746@code.launchpad.net

Commit message

debian/tests: drop which usage to fix adt failure in jammy

Command which is obsolete, and prints warnings to stderr now. Replace it with python standard library call to shutil.which().

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index e250835..1c00736 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+network-manager (1.32.12-0ubuntu2) jammy; urgency=medium
7+
8+ * debian/tests: drop which usage to fix adt failure in jammy
9+
10+ -- Dimitri John Ledkov <dimitri.ledkov@canonical.com> Thu, 11 Nov 2021 12:07:34 +0000
11+
12 network-manager (1.32.12-0ubuntu1) impish; urgency=medium
13
14 * New upstream version
15diff --git a/debian/tests/network_test_base.py b/debian/tests/network_test_base.py
16index 2adbbd4..221aad1 100644
17--- a/debian/tests/network_test_base.py
18+++ b/debian/tests/network_test_base.py
19@@ -15,6 +15,7 @@ import os
20 import os.path
21 import time
22 import tempfile
23+import shutil
24 import subprocess
25 import re
26 import unittest
27@@ -25,7 +26,7 @@ from glob import glob
28 # check availability of programs, and cleanly skip test if they are not
29 # available
30 for program in ["wpa_supplicant", "hostapd", "dnsmasq", "dhclient"]:
31- if subprocess.call(["which", program], stdout=subprocess.PIPE) != 0:
32+ if shutil.which(program) is None:
33 sys.stderr.write(
34 "%s is required for this test suite, but not available. Skipping\n"
35 % program

Subscribers

People subscribed via source and target branches