Merge lp:~xnox/location-service/drop-sys-events into lp:location-service/trunk

Proposed by Dimitri John Ledkov on 2015-01-11
Status: Needs review
Proposed branch: lp:~xnox/location-service/drop-sys-events
Merge into: lp:location-service/trunk
Diff against target: 19 lines (+7/-2)
1 file modified
data/ubuntu-location-service-trust-stored.conf.in (+7/-2)
To merge this branch: bzr merge lp:~xnox/location-service/drop-sys-events
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2015-01-11
Martin Pitt 2015-01-17 Pending
Ubuntu Phablet Team 2015-01-11 Pending
Review via email: mp+246050@code.launchpad.net

Commit message

Migrate from :sys:started events to dbus owner signals.

Description of the change

Migrate from :sys:started events to dbus owner signals.

To post a comment you must log in.
Dimitri John Ledkov (xnox) wrote :

When system upstart goes away, :sys:started/stopped/starting/stopping events will go away.

One option is to introduce a user session event bridge which will relay similar events from systemd. I have a working prototype for that, however incomplete information is exposed by systemd at the moment.

Another option is to key onto approximately equivalent events which are already available.

This is a master bug to track all users and port them.

Unmerged revisions

156. By Dimitri John Ledkov on 2015-01-11

Migrate from :sys:started events to dbus owner signals.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/ubuntu-location-service-trust-stored.conf.in'
2--- data/ubuntu-location-service-trust-stored.conf.in 2014-09-19 14:36:51 +0000
3+++ data/ubuntu-location-service-trust-stored.conf.in 2015-01-11 00:44:23 +0000
4@@ -3,9 +3,14 @@
5 # try to start this on session startup or once ubuntu-location-service finished
6 # starting; if dbus is available and location-service isn't or vice-versa,
7 # startup will fail but the next event firing will trigger another start
8+#
9+# Start on session dbus is spawned on ubuntu-touch session or
10+# com.ubuntu.location.Service bus name appears on system dbus
11+# Stop on desktop end or com.ubuntu.location.Service bus name disappearing on system dbus
12 start on (started dbus and xsession SESSION=ubuntu-touch) or \
13- :sys:started JOB=ubuntu-location-service
14-stop on desktop-end or :sys:stopping JOB=ubuntu-location-service
15+ dbus SIGNAL='NameOwnerChanged' BUS='system' INTERFACE='org.freedesktop.DBus' OBJPATH='/org/freedesktop/DBus' SENDER='org.freedesktop.DBus' ARG0='com.ubuntu.location.Service' ARG1='' ARG2='*'
16+stop on desktop-end or \
17+ dbus SIGNAL='NameOwnerChanged' BUS='system' INTERFACE='org.freedesktop.DBus' OBJPATH='/org/freedesktop/DBus' SENDER='org.freedesktop.DBus' ARG0='com.ubuntu.location.Service' ARG1='*' ARG2=''
18
19 respawn
20

Subscribers

People subscribed via source and target branches