Merge lp:~xnox/indicator-session/unbreak-ubiquity into lp:indicator-session/14.04

Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Dimitri John Ledkov
Proposed branch: lp:~xnox/indicator-session/unbreak-ubiquity
Merge into: lp:indicator-session/14.04
Diff against target: 87 lines (+21/-19)
5 files modified
.bzrignore (+1/-0)
data/CMakeLists.txt (+9/-10)
data/indicator-session.desktop.in (+0/-9)
data/indicator-session.service.in (+3/-0)
debian/changelog (+8/-0)
To merge this branch: bzr merge lp:~xnox/indicator-session/unbreak-ubiquity
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+198178@code.launchpad.net

Commit message

* Make indicator-session DBus activated for ubiquity/lightdm (LP: #1258863):
  - Drop XDG autostart file, not needed
  - Reintroduce DBus activation file

Description of the change

* Make indicator-session DBus activated for ubiquity/lightdm (LP: #1258863):
  - Drop XDG autostart file, not needed
  - Reintroduce DBus activation file

To post a comment you must log in.
426. By Dimitri John Ledkov

Mark debian/rules as executable.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

This MR should wait for the resolution of sibling MR https://code.launchpad.net/~xnox/indicator-sound/unbreak-ubiquity/+merge/198170, since that's where xnox and ted seem to be hashing out the details of the change

Unmerged revisions

426. By Dimitri John Ledkov

Mark debian/rules as executable.

425. By Dimitri John Ledkov

* Make indicator-session DBus activated for ubiquity/lightdm (LP: #1258863):
  - Drop XDG autostart file, not needed
  - Reintroduce DBus activation file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2013-05-29 19:37:22 +0000
3+++ .bzrignore 2013-12-08 20:30:28 +0000
4@@ -254,3 +254,4 @@
5 dbus-user.h
6 tests/test-service
7 indicator-session.conf
8+indicator-session.service
9
10=== modified file 'data/CMakeLists.txt'
11--- data/CMakeLists.txt 2013-10-29 00:31:50 +0000
12+++ data/CMakeLists.txt 2013-12-08 20:30:28 +0000
13@@ -38,25 +38,24 @@
14
15
16 ##
17-## XDG Autostart Config File
18+## DBus Service File
19 ##
20
21 # where to install
22-set (XDG_AUTOSTART_DIR "/etc/xdg/autostart")
23-message (STATUS "${XDG_AUTOSTART_DIR} is the XDG Autostart install dir")
24+set (DBUS_SERVICE_DIR "${CMAKE_INSTALL_FULL_DATADIR}/dbus-1/services")
25+message (STATUS "${DBUS_SERVICE_DIR} is the DBus Service File install dir")
26
27-set (XDG_AUTOSTART_NAME "${CMAKE_PROJECT_NAME}.desktop")
28-set (XDG_AUTOSTART_FILE "${CMAKE_CURRENT_BINARY_DIR}/${XDG_AUTOSTART_NAME}")
29-set (XDG_AUTOSTART_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${XDG_AUTOSTART_NAME}.in")
30+set (SERVICE_NAME "${CMAKE_PROJECT_NAME}.service")
31+set (SERVICE_FILE "${CMAKE_CURRENT_BINARY_DIR}/${SERVICE_NAME}")
32+set (SERVICE_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${SERVICE_NAME}.in")
33
34 # build it
35 set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
36-configure_file ("${XDG_AUTOSTART_FILE_IN}" "${XDG_AUTOSTART_FILE}")
37+configure_file ("${SERVICE_FILE_IN}" "${SERVICE_FILE}")
38
39 # install it
40-install (FILES "${XDG_AUTOSTART_FILE}"
41- DESTINATION "${XDG_AUTOSTART_DIR}")
42-
43+install (FILES "${SERVICE_FILE}"
44+ DESTINATION "${DBUS_SERVICE_DIR}")
45
46 ##
47 ## Unity Indicator File
48
49=== removed file 'data/indicator-session.desktop.in'
50--- data/indicator-session.desktop.in 2013-10-29 00:31:50 +0000
51+++ data/indicator-session.desktop.in 1970-01-01 00:00:00 +0000
52@@ -1,9 +0,0 @@
53-[Desktop Entry]
54-Type=Application
55-Name=Indicator Session
56-Exec=@pkglibexecdir@/indicator-session-service
57-NotShowIn=Unity;
58-NoDisplay=true
59-StartupNotify=false
60-Terminal=false
61-
62
63=== added file 'data/indicator-session.service.in'
64--- data/indicator-session.service.in 1970-01-01 00:00:00 +0000
65+++ data/indicator-session.service.in 2013-12-08 20:30:28 +0000
66@@ -0,0 +1,3 @@
67+[D-BUS Service]
68+Name=com.canonical.indicator.session
69+Exec=@pkglibexecdir@/indicator-session-service
70
71=== modified file 'debian/changelog'
72--- debian/changelog 2013-11-25 03:57:00 +0000
73+++ debian/changelog 2013-12-08 20:30:28 +0000
74@@ -1,3 +1,11 @@
75+indicator-session (12.10.5+14.04.20131125-0ubuntu2) UNRELEASED; urgency=low
76+
77+ * Make indicator-session DBus activated for ubiquity/lightdm (LP: #1258863):
78+ - Drop XDG autostart file, not needed
79+ - Reintroduce DBus activation file
80+
81+ -- Dmitrijs Ledkovs <xnox@ubuntu.com> Sun, 08 Dec 2013 20:24:02 +0000
82+
83 indicator-session (12.10.5+14.04.20131125-0ubuntu1) trusty; urgency=low
84
85 [ Charles Kerr ]
86
87=== modified file 'debian/rules' (properties changed: -x to +x)

Subscribers

People subscribed via source and target branches