Merge lp:~xnox/indicator-network/lp1648360 into lp:indicator-network

Proposed by Dimitri John Ledkov
Status: Merged
Approved by: Pete Woods
Approved revision: 649
Merged at revision: 660
Proposed branch: lp:~xnox/indicator-network/lp1648360
Merge into: lp:indicator-network
Diff against target: 95 lines (+1/-60)
5 files modified
data/CMakeLists.txt (+0/-42)
data/indicator-network.desktop.in (+0/-8)
data/indicator-network.upstart.desktop.in (+0/-8)
debian/indicator-network.install (+0/-2)
debian/indicator-network.maintscript (+1/-0)
To merge this branch: bzr merge lp:~xnox/indicator-network/lp1648360
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+312847@code.launchpad.net

Commit message

Remove xdg autolaunch desktop files

Description of the change

Remove xdg autolaunch desktop files because they are redundant in zesty and up, and do not work correctly in the zesty systemd unity7 session.

All systems have systemd user sessions now, and if one wants this indicator in particular session they should be a .wants symlink shipped.

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/CMakeLists.txt'
2--- data/CMakeLists.txt 2016-07-19 10:15:52 +0000
3+++ data/CMakeLists.txt 2016-12-08 16:52:48 +0000
4@@ -100,45 +100,3 @@
5 ###########################
6
7 add_schema ("com.canonical.indicator.network.gschema.xml")
8-
9-###########################
10-# XDG Autostart File
11-###########################
12-
13-# where to install
14-set (XDG_AUTOSTART_DIR "/etc/xdg/autostart")
15-message (STATUS "${XDG_AUTOSTART_DIR} is the DBus Service File install dir")
16-
17-set (XDG_AUTOSTART_NAME "${CMAKE_PROJECT_NAME}.desktop")
18-set (XDG_AUTOSTART_FILE "${CMAKE_CURRENT_BINARY_DIR}/${XDG_AUTOSTART_NAME}")
19-set (XDG_AUTOSTART_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${XDG_AUTOSTART_NAME}.in")
20-
21-# build it
22-set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
23-configure_file ("${XDG_AUTOSTART_FILE_IN}" "${XDG_AUTOSTART_FILE}")
24-
25-# install it
26-install (FILES "${XDG_AUTOSTART_FILE}"
27- DESTINATION "${XDG_AUTOSTART_DIR}")
28-
29-###########################
30-# Upstart XDG Autostart Override
31-###########################
32-
33-# where to install
34-set (UPSTART_XDG_AUTOSTART_DIR "${CMAKE_INSTALL_FULL_DATAROOTDIR}/upstart/xdg/autostart")
35-message (STATUS "${UPSTART_XDG_AUTOSTART_DIR} is the Upstart XDG autostart override dir")
36-
37-set (UPSTART_XDG_AUTOSTART_NAME "${CMAKE_PROJECT_NAME}.upstart.desktop")
38-set (UPSTART_XDG_AUTOSTART_FILE "${CMAKE_CURRENT_BINARY_DIR}/${UPSTART_XDG_AUTOSTART_NAME}")
39-set (UPSTART_XDG_AUTOSTART_FILE_IN "${CMAKE_CURRENT_SOURCE_DIR}/${UPSTART_XDG_AUTOSTART_NAME}.in")
40-
41-# build it
42-set (pkglibexecdir "${CMAKE_INSTALL_FULL_PKGLIBEXECDIR}")
43-configure_file ("${UPSTART_XDG_AUTOSTART_FILE_IN}" "${UPSTART_XDG_AUTOSTART_FILE}")
44-
45-# install it
46-install (FILES "${UPSTART_XDG_AUTOSTART_FILE}"
47- DESTINATION "${UPSTART_XDG_AUTOSTART_DIR}"
48- RENAME "${XDG_AUTOSTART_NAME}")
49-
50
51=== removed file 'data/indicator-network.desktop.in'
52--- data/indicator-network.desktop.in 2014-02-26 16:37:56 +0000
53+++ data/indicator-network.desktop.in 1970-01-01 00:00:00 +0000
54@@ -1,8 +0,0 @@
55-[Desktop Entry]
56-Type=Application
57-Name=Indicator Network
58-Exec=@NETWORK_SERVICE@
59-StartupNotify=false
60-Terminal=false
61-OnlyShowIn=Unity;GNOME;
62-AutostartCondition=GNOME3 unless-session gnome
63
64=== removed file 'data/indicator-network.upstart.desktop.in'
65--- data/indicator-network.upstart.desktop.in 2014-04-09 20:49:14 +0000
66+++ data/indicator-network.upstart.desktop.in 1970-01-01 00:00:00 +0000
67@@ -1,8 +0,0 @@
68-[Desktop Entry]
69-Type=Application
70-Name=Indicator Network
71-Exec=@NETWORK_SERVICE@
72-StartupNotify=false
73-Terminal=false
74-Hidden=true
75-OnlyShowIn=Unity;
76
77=== modified file 'debian/indicator-network.install'
78--- debian/indicator-network.install 2016-07-19 10:15:52 +0000
79+++ debian/indicator-network.install 2016-12-08 16:52:48 +0000
80@@ -1,9 +1,7 @@
81-usr/share/upstart/xdg/autostart/indicator-network.desktop
82 usr/share/upstart/sessions/*
83 usr/share/upstart/systemd-session
84 usr/share/glib-2.0/schemas/com.canonical.indicator.network.gschema.xml
85 usr/share/unity/indicators/com.canonical.indicator.network
86 usr/lib/*/indicator-network/*
87 usr/lib/systemd
88-etc/xdg/autostart/indicator-network.desktop
89 usr/share/locale
90
91=== added file 'debian/indicator-network.maintscript'
92--- debian/indicator-network.maintscript 1970-01-01 00:00:00 +0000
93+++ debian/indicator-network.maintscript 2016-12-08 16:52:48 +0000
94@@ -0,0 +1,1 @@
95+rm_conffile etc/xdg/autostart/indicator-network.desktop

Subscribers

People subscribed via source and target branches