Code review comment for lp:~xnox/indicator-datetime/clickanywhere

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

I could notice two issues related to memory management:

in sync_location(), a GSettings object is created but not g_object_unref'd.

in tz_changed(), char* name is added and it seems to me like it should be freed.

Otherwise, thanks for including the commits from Seb/Ryan I hadn't had time to merge into the branch yet :)

Note, this is the incorrect branch if you intend for this to land in raring; you'll want to merge into lp:indicator-datetime/13.04 instead. (I think this is due to the default landing branch automatically selected by Launchpad)

Assuming you indeed want to land in the other branch, please don't delete this merge, it should land in both trunks :)

review: Needs Fixing

« Back to merge proposal