Merge lp:~xnox/debian-cd/only-start-maybe-ubiquity into lp:~ubuntu-cdimage/debian-cd/ubun3

Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Iain Lane
Proposed branch: lp:~xnox/debian-cd/only-start-maybe-ubiquity
Merge into: lp:~ubuntu-cdimage/debian-cd/ubun3
Diff against target: 25 lines (+2/-2)
2 files modified
tools/boot/cosmic/boot-amd64 (+1/-1)
tools/boot/cosmic/boot-i386 (+1/-1)
To merge this branch: bzr merge lp:~xnox/debian-cd/only-start-maybe-ubiquity
Reviewer Review Type Date Requested Status
Dimitri John Ledkov (community) Needs Fixing
Steve Langasek Needs Information
Martin Wimpress  Pending
Review via email: mp+357002@code.launchpad.net

Commit message

Switch ubuntu to only `Start` in maybe-ubiquity mode, in gfx & grub boot.

Description of the change

Switch ubuntu to only `Start` in maybe-ubiquity mode, in gfx & grub boot.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

This will result in Ubuntu having two options:
 Start Ubuntu
 Install Ubuntu

instead of the current options:
 Try Ubuntu without installing
 Install Ubuntu

Where does this change originate? Is this requested by the Desktop Team? Does the change have Design Team signoff?

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Currently, we have 3x and 2x options, for gfxboot and uefi boot respectively.

The gfxboot theme encodes the default of maybe-ubiquity which is hidden; and then displays two text options of only-ubiquity and `try`.

On uefi, there is no hidden menu and only 2x only-ubiquity and `try`.

The proposed option will be 1x only, for both gfxboot and uefi boot, which is just `maybe-ubiquity` this is due to setting NOTRYONLYDO=true variable in that case, which does not generate `Install Ubuntu` option at all..

This is to unify the boot to always boot to maybe-ubiquity. Especially on uefi.

This change originates from the release sprint, acked by willcooke, and fact that the most common boot method, uefi, never uses the pretty maybe-ubiquity welcome screen.

Design team - no idea who would that be, but must people vomit upon seeing EFI grub...

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

If you want to test this option, download kubuntu daily-live image, and test it in gfxboot (default timeout), opening gfxboot menu, booting in UEFI mode.

Revision history for this message
Steve Langasek (vorlon) wrote :

Ah yes of course, sorry, you're adding this to a section that already has NOTRYONLYDO=yes, so as you say there's only one option being presented at that point.

I do think we should plan to have a high-level design review of these flows (informed by the limitations of the different bootloaders) rather than making incremental adjustments here.

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

I have concerns about breaking translated strings this late in the cycle, but happy to work on this directly after 20.10 opens.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

UEFI grub menu entries are not translated, there is no translations impact.

BIOS boot remains the same, silently booting into maybe-ubiquity, with try/install options offered if people press esc on keyboard.

Revision history for this message
Sebastien Bacher (seb128) wrote :

The commit message states 'in gfx & grub boot', is the string changed or not in gfx boot?
If not then it's inconsistent
It it is then you break translations

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I'll resubmit a clean one then, on top of current debian-cd branch and the right series! (pointed out on irc)

review: Needs Fixing

Unmerged revisions

2005. By Dimitri John Ledkov on 2018-10-17

Switch ubuntu to only `Start` in maybe-ubiquity mode, in gfx & grub boot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/boot/cosmic/boot-amd64'
2--- tools/boot/cosmic/boot-amd64 2018-07-12 05:26:32 +0000
3+++ tools/boot/cosmic/boot-amd64 2018-10-17 20:39:46 +0000
4@@ -420,7 +420,7 @@
5 QUIET=quiet
6 SPLASH=splash
7 case "$PROJECT" in
8- kubuntu|kubuntu-plasma5)
9+ ubuntu|kubuntu|kubuntu-plasma5)
10 livelabel="^Start $HUMANPROJECT"
11 liveparams=' maybe-ubiquity'
12 NOTRYONLYDO=true
13
14=== modified file 'tools/boot/cosmic/boot-i386'
15--- tools/boot/cosmic/boot-i386 2018-09-30 20:16:30 +0000
16+++ tools/boot/cosmic/boot-i386 2018-10-17 20:39:46 +0000
17@@ -381,7 +381,7 @@
18 EOF
19 if [ "$CDIMAGE_LIVE" = 1 ]; then
20 case "$PROJECT" in
21- kubuntu|kubuntu-plasma5)
22+ ubuntu|kubuntu|kubuntu-plasma5)
23 livelabel="^Start $HUMANPROJECT"
24 liveparams=' maybe-ubiquity'
25 NOTRYONLYDO=true

Subscribers

People subscribed via source and target branches