Code review comment for lp:~xnox/cuneiform-linux/fix-missing-libm

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 27 April 2010 12:49, JussiP <email address hidden> wrote:
> I don't want to merge this immediately because:
>
> a) it's not required for build on any platform
> b) I don't know what MSVC etc will do, especially since other libraries that use sqrt seem to work fine
>
> I suggest that this is kept as a Debian distro patch for the moment.

Fair enough =) i've tested this across a few debian/ubuntu releases in
a chroot environments. I do not have access to MSVC/msys platforms.

Please do not unlink this branch from the bug report =) cause that's
the url I'm using to describe the patch (where it came from & why) for
debian packaging we need to document that ;-)

Please note that everywhere else in the codebase long_sqrt() is used
not sqrt() maybe that's the cause of the problem?

« Back to merge proposal