bzr-builddeb

Merge lp:~xnox/bzr-builddeb/fix-tar into lp:bzr-builddeb

  1. fix-tar
  2. Merge into trunk
Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Robert Collins
Proposed branch: lp:~xnox/bzr-builddeb/fix-tar
Merge into: lp:bzr-builddeb
Diff against target: 12 lines (+1/-1)
1 file modified
import_dsc.py (+1/-1)
To merge this branch: bzr merge lp:~xnox/bzr-builddeb/fix-tar
Reviewer Review Type Date Requested Status
Bzr-builddeb-hackers Pending
Review via email: mp+18363@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Robert was right.

import_dsc was not failing because it uses dpkg-source -x

Here is quick fix. Works like a charm for me now on Karmic

Revision history for this message
Robert Collins (lifeless) wrote :

Heh, we've come up with the same solution. I'll mark this one as
obsoleted so we don't try to do it twice :P

-Rob

Unmerged revisions

398. By Dimitri John Ledkov

Do not use absolute path for tar

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'import_dsc.py'
2--- import_dsc.py 2009-12-18 12:58:41 +0000
3+++ import_dsc.py 2010-02-01 06:00:34 +0000
4@@ -1590,7 +1590,7 @@
5 def _extract_tarball_to_tempdir(self, tarball_filename):
6 tempdir = tempfile.mkdtemp()
7 try:
8- proc = Popen(["/usr/bin/tar", "xzf", tarball_filename, "-C",
9+ proc = Popen(["tar", "xzf", tarball_filename, "-C",
10 tempdir, "--strip-components", "1"],
11 preexec_fn=subprocess_setup)
12 proc.communicate()

Subscribers

People subscribed via source and target branches