Bileto

Merge ~xnox/bileto:master into bileto:master

  1. Git
  2. lp:~xnox/bileto
  3. master
  4. Merge into master
Proposed by Dimitri John Ledkov
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 5fe858ce0ab8051ec0dadcf5f709b901d9a7d676
Merged at revision: 5fe858ce0ab8051ec0dadcf5f709b901d9a7d676
Proposed branch: ~xnox/bileto:master
Merge into: bileto:master
Diff against target: 13 lines (+1/-1)
1 file modified
britney/britney.conf.in (+1/-1)
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+359753@code.launchpad.net

Commit message

Or adjust the real production britney.conf

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Did you run the bileto test suite on this change? This should give us some info.

review: Needs Fixing
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

...this was supposed to be 'Needs Information'.

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

@sil2100 how do I do that?

$ make check
ModuleNotFoundError: No module named 'flask.ext'

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

You have to run it on a 'supported' environment - what I usually do is run those in an xenial lxc container after installing all the dependencies as listed in debian/control. But I just gave your branch a spin and everything seems to work as expected. Let's try giving it a spin in production.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/britney/britney.conf.in b/britney/britney.conf.in
2index 3767966..6839232 100644
3--- a/britney/britney.conf.in
4+++ b/britney/britney.conf.in
5@@ -61,7 +61,7 @@ REMOVE_OBSOLETE = no
6 ADT_ENABLE = yes
7 ADT_DEBUG = no
8 ADT_ARCHES = amd64 i386 armhf ppc64el s390x
9-ADT_PPAS = @TEAM@/@OVERLAY@ @TEAM@/@PPA@
10+ADT_PPAS = @TEAM@/@PPA@
11 ADT_SHARED_RESULTS_CACHE = /tmp/britney_data/%(SERIES)/results.cache
12 ADT_AMQP = @AMQP_URI@
13 # Swift base URL with the results (must be publicly readable and browsable)

Subscribers

People subscribed via source and target branches