Merge ~xnox/autopkgtest-cloud/+git/autopkgtest-package-configs:never-run-eol-kernels into ~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-package-configs:main

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: d50dbfca09be67a8b5046d2362d7347087001348
Proposed branch: ~xnox/autopkgtest-cloud/+git/autopkgtest-package-configs:never-run-eol-kernels
Merge into: ~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-package-configs:main
Diff against target: 64 lines (+56/-0)
1 file modified
never_run (+56/-0)
Reviewer Review Type Date Requested Status
Brian Murray Needs Information
Review via email: mp+432970@code.launchpad.net

Commit message

Add EOL kernels to never_run

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I'm pretty sure all doesn't work in the never run file. Did you do any investigation to see if it does?

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

> I'm pretty sure all doesn't work in the never run file. Did you do any
> investigation to see if it does?

def request_matches_per_package(package, arch, release, s):
    return (any(fnmatch.fnmatchcase(f"{package}/{arch}/{release}", entry) for entry in s) or
            any(fnmatch.fnmatchcase(f"{package}/{arch}/all", entry) for entry in s) or
            any(fnmatch.fnmatchcase(f"{package}/all/all", entry) for entry in s))

It seems correct that one can match on "all" releases, and all arches & all releases, but not on all arches with specific release.

Should we add support for

            any(fnmatch.fnmatchcase(f"{package}/all/{release}", entry) for entry in s) or

It seems like that would collapse a few existing never_run hints as well.

Revision history for this message
Brian Murray (brian-murray) wrote :

Yes, adding support for that makes sense to me and would help with adding packages from debian's reject_list to our never_run list.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

> Yes, adding support for that makes sense to me and would help with adding
> packages from debian's reject_list to our never_run list.

https://code.launchpad.net/~xnox/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/433133

making it so

Revision history for this message
Paride Legovini (paride) wrote :

autopkgtest-cloud MP merged, but the change will require a charm update to go live.

Revision history for this message
Brian Murray (brian-murray) wrote :

Out of an abundance of caution we should probably hold off on merging this until after the charm update has landed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/never_run b/never_run
2index 2c5b988..e821e3b 100644
3--- a/never_run
4+++ b/never_run
5@@ -99,3 +99,59 @@ cryptsetup/arm64/kinetic
6 cryptsetup/i386/kinetic
7 cryptsetup/ppc64el/kinetic
8 cryptsetup/s390x/kinetic
9+
10+# Never run EOL kernels ADT-165
11+# generated with kteam-tools/stable/swm-autopkgtest-config
12+# update approximately every 6 months
13+#
14+linux-adv-uno420/all/focal
15+linux-adv-uno420-uc20-efi/all/focal
16+linux-aws-5.11/all/focal
17+linux-aws-5.13/all/focal
18+linux-aws-5.8/all/focal
19+linux-azure-5.11/all/focal
20+linux-azure-5.13/all/focal
21+linux-azure-5.8/all/focal
22+linux-gcp-5.11/all/focal
23+linux-gcp-5.13/all/focal
24+linux-gcp-5.8/all/focal
25+linux-hwe-5.11/all/focal
26+linux-hwe-5.13/all/focal
27+linux-hwe-5.8/all/focal
28+linux-intel/all/focal
29+linux-intel-5.13/all/focal
30+linux-oem-5.10/all/focal
31+linux-oem-5.13/all/focal
32+linux-oem-5.6/all/focal
33+linux-oracle-5.11/all/focal
34+linux-oracle-5.13/all/focal
35+linux-oracle-5.8/all/focal
36+linux-raspi2/all/focal
37+linux-riscv/all/focal
38+linux-riscv-5.11/all/focal
39+linux-riscv-5.13/all/focal
40+linux-riscv-5.8/all/focal
41+linux-uc20-intel/all/focal
42+linux-aws-5.0/all/bionic
43+linux-aws-5.3/all/bionic
44+linux-aws-edge/all/bionic
45+linux-azure/all/bionic
46+linux-azure-5.3/all/bionic
47+linux-azure-edge/all/bionic
48+linux-bluefield/all/bionic
49+linux-denver/all/bionic
50+linux-gcp/all/bionic
51+linux-gcp-5.3/all/bionic
52+linux-gcp-edge/all/bionic
53+linux-gke-4.15/all/bionic
54+linux-gke-5.0/all/bionic
55+linux-gke-5.3/all/bionic
56+linux-gke-5.4/all/bionic
57+linux-gkeop-5.4/all/bionic
58+linux-hwe/all/bionic
59+linux-hwe-5.0/all/bionic
60+linux-mt8516/all/bionic
61+linux-oem/all/bionic
62+linux-oracle-5.0/all/bionic
63+linux-oracle-5.3/all/bionic
64+linux-raspi2-5.3/all/bionic

Subscribers

People subscribed via source and target branches