Merge lp:~xnox/auto-package-testing/haveged-random into lp:auto-package-testing

Proposed by Dimitri John Ledkov
Status: Work in progress
Proposed branch: lp:~xnox/auto-package-testing/haveged-random
Merge into: lp:auto-package-testing
Diff against target: 26 lines (+1/-5)
2 files modified
bin/prepare-testbed (+1/-0)
bin/testbed/run-adt (+0/-5)
To merge this branch: bzr merge lp:~xnox/auto-package-testing/haveged-random
Reviewer Review Type Date Requested Status
Auto Package Testing Developers Pending
Review via email: mp+139868@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

How is that better than /dev/urandom?

Also, I think a better fix would be to just create a GPG key statically and include that in bzr, and install it in the VM. Or even better, add an option to autopkgtest to not insist on having a GPG key in the first place, as this is absolutely unnecessary for running autopkgtest.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I am not competent enough to compare haveged quality with urandom.

Inherently VMs don't have a good source of entropy & it gets depleted rather quickly. Enough entropy is required not only for the initial gpg key, but for many tests as well. One way or another, we want to speed up gathering entropy.

I am proposing to drop 3 lines of code hack & use one-line to set up a fast entropy source via a managed package.

Unmerged revisions

130. By Dimitri John Ledkov

Use packaged fast random number generator haveged

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/prepare-testbed'
2--- bin/prepare-testbed 2012-12-12 13:41:19 +0000
3+++ bin/prepare-testbed 2012-12-14 10:51:40 +0000
4@@ -207,6 +207,7 @@
5 - dpkg-dev
6 - pbuilder
7 - bzr
8+ - haveged
9
10 runcmd:
11 - [sh, -xc, "echo '127.0.1.1 $LOCALHOSTNAME' >> /etc/hosts" ]
12
13=== modified file 'bin/testbed/run-adt'
14--- bin/testbed/run-adt 2012-11-29 06:04:48 +0000
15+++ bin/testbed/run-adt 2012-12-14 10:51:40 +0000
16@@ -120,11 +120,6 @@
17 apt-get -y --force-yes dist-upgrade
18 apt-get clean
19
20-# Faster random number generator for gpg key creation
21-mknod /dev/newrandom c 1 9
22-chmod --reference=/dev/random /dev/newrandom
23-mv -f /dev/newrandom /dev/random
24-
25 # Clean-up /var/crash
26 rm -f /var/crash/*
27

Subscribers

People subscribed via source and target branches