Merge lp:~xnox/apt-btrfs-snapshot/tools2progs into lp:apt-btrfs-snapshot

Proposed by Dimitri John Ledkov
Status: Needs review
Proposed branch: lp:~xnox/apt-btrfs-snapshot/tools2progs
Merge into: lp:apt-btrfs-snapshot
Diff against target: 81 lines (+12/-8)
5 files modified
apt-btrfs-snapshot (+0/-4)
apt_btrfs_snapshot.py (+3/-3)
debian/changelog (+7/-0)
debian/control (+1/-1)
test/test_apt_btrfs_snapshot.py (+1/-0)
To merge this branch: bzr merge lp:~xnox/apt-btrfs-snapshot/tools2progs
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+346538@code.launchpad.net

Commit message

tools got renamed to progs, and the transitional package is now being dropped.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

ah, and this fails to build, because of new pyflakes / pep8. Oh, well, will need to refix that too.

56. By Dimitri John Ledkov

Fix new pep8/pyflakes warnings.

Unmerged revisions

56. By Dimitri John Ledkov

Fix new pep8/pyflakes warnings.

55. By Dimitri John Ledkov

Change btrfs-tools dependency to progs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'apt-btrfs-snapshot'
2--- apt-btrfs-snapshot 2015-10-16 09:27:08 +0000
3+++ apt-btrfs-snapshot 2018-05-23 10:13:00 +0000
4@@ -19,13 +19,9 @@
5
6
7 import argparse
8-import datetime
9 import logging
10 import os
11-import string
12-import subprocess
13 import sys
14-import tempfile
15
16 import gettext
17 from gettext import gettext as _
18
19=== modified file 'apt_btrfs_snapshot.py'
20--- apt_btrfs_snapshot.py 2016-04-29 15:13:38 +0000
21+++ apt_btrfs_snapshot.py 2018-05-23 10:13:00 +0000
22@@ -184,7 +184,7 @@
23 If "older_then" is given (in unixtime format) it will only include
24 snapshots that are older then the given date)
25 """
26- l = []
27+ result = []
28 # if older_than is used, ensure that the rootfs does not use
29 # "noatime"
30 if older_than != 0:
31@@ -203,9 +203,9 @@
32 # created (to check if there is support for btrfs)
33 atime = os.path.getatime(os.path.join(mp, e, "etc", "fstab"))
34 if atime < older_than:
35- l.append(e)
36+ result.append(e)
37 self.umount_btrfs_root_volume()
38- return l
39+ return result
40
41 def print_btrfs_root_snapshots(self):
42 print("Available snapshots:")
43
44=== modified file 'debian/changelog'
45--- debian/changelog 2016-04-29 15:13:38 +0000
46+++ debian/changelog 2018-05-23 10:13:00 +0000
47@@ -1,3 +1,10 @@
48+apt-btrfs-snapshot (3.5.2) cosmic; urgency=medium
49+
50+ * Change btrfs-tools dependency to progs.
51+ * Fix new pep8/pyflakes warnings.
52+
53+ -- Dimitri John Ledkov <xnox@ubuntu.com> Tue, 22 May 2018 10:56:22 +0100
54+
55 apt-btrfs-snapshot (3.5.1) yakkety; urgency=medium
56
57 * fix mock of "btrfs" binary
58
59=== modified file 'debian/control'
60--- debian/control 2012-10-26 09:27:26 +0000
61+++ debian/control 2018-05-23 10:13:00 +0000
62@@ -21,7 +21,7 @@
63 Depends: ${python:Depends},
64 ${python3:Depends},
65 ${misc:Depends},
66- btrfs-tools
67+ btrfs-progs
68 Description: Automatically create snapshot on apt operations
69 This will create a btrfs snapshot of the root filesystem each time
70 that apt installs/removes/upgrades a software package.
71
72=== modified file 'test/test_apt_btrfs_snapshot.py'
73--- test/test_apt_btrfs_snapshot.py 2016-04-29 15:13:38 +0000
74+++ test/test_apt_btrfs_snapshot.py 2018-05-23 10:13:00 +0000
75@@ -126,5 +126,6 @@
76 t = apt_btrfs._parse_older_than_to_unixtime("5d")
77 self.assertTrue((t < time.time()) - (5 * 60 * 60 * 24))
78
79+
80 if __name__ == "__main__":
81 unittest.main()

Subscribers

People subscribed via source and target branches