Merge lp:~xmo-deactivatedaccount/openobject-client-web/layout-fixes into lp:openobject-client-web/trunk

Proposed by Xavier (Open ERP)
Status: Merged
Merged at revision: 3397
Proposed branch: lp:~xmo-deactivatedaccount/openobject-client-web/layout-fixes
Merge into: lp:openobject-client-web/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~xmo-deactivatedaccount/openobject-client-web/layout-fixes
Reviewer Review Type Date Requested Status
Navrang Oza (community) Needs Fixing
Sananaz (Open ERP) Pending
OpenERP R&D Web Team Pending
Review via email: mp+34676@code.launchpad.net

Description of the change

* Removal of various layouting javascript (adjustTopWidht, setRowWidth) for improved reliability
* Fix of the top bar layout (100% always automatically)
* Migration of central layout to table in order to get rid of JS for accordion height
* Simplification and unification of M2O widgets (regular and search)
* Cleanup of template in search filters
* Reduction of width of search text controls (for more horizontal room and less horizontal scrolling when possible)
* Merge of filters within controls (text inputs) into them at display time (remove space between field and its filter(s))
* Removal of dead/redundant code (Notebook in Search view parsing, type test on both TinyInputWidget and RangeWidget, wrapper around exception with only role of losing exception details)

Know minor issues to be handled later (after merge):
* Weird spacings in search view

To post a comment you must log in.
3208. By Chirag Patel (OpenERP)

[FIX] fixed pagination images.

3209. By Kunal Chavda

[FIX] Correction in editable List view for error message.

Revision history for this message
Navrang Oza (noz-tiny) wrote :

- Only Right sidebar (not left) toggling breaking full width (Try in dashboard).
Its not considering 100% width of header.

- In any form view, right sidebar takes extra spaces (small horizontal scrollbar).

Rest of the things are working fine.
Thanks for the efforts.

review: Needs Fixing
3210. By Kunal Chavda

[FIX] Fixed swiching form views on Manage Filters.

3211. By Sananaz (Open ERP)

[FIX] Fixed set default.

3212. By ksh (Axelor)

[IMP] Remove tool bar from diagram view, replace by regular buttons

3213. By Chirag Patel (OpenERP)

[FIX] set background color for group_by.

3214. By Sananaz (Open ERP)

[FIX] Fixed selection widget for search view.

3215. By Vaibhav Darji

[FIX] Minor changes for button in listgroup.

3216. By Jiten (OpenERP)

[IMP] Improved Help screen.

3217. By Vaibhav Darji

[FIX] Fixed target for reports to avoid xhr request (appContent).

3218. By Vaibhav Darji

[FIX] Form Validation.

3219. By Vaibhav Darji

[FIX] Minor changes for button font-size.

3220. By Sananaz (Open ERP)

[IMP] Fixed search view, use fields_get instead of calling reading data directly from ir.model.fields.

3221. By Vaibhav Darji

[FIX] Fixed views issues when clicking on graph.

3222. By Vaibhav Darji

[FIX] Fixed for save_filter.

3223. By Sananaz (Open ERP)

[IMP] Improve error page looks.

3224. By Xavier (Open ERP)

[IMP] remove unneeded test before iteration

3225. By Xavier (Open ERP)

[IMP] exclusive tests are exclusive

3226. By Sananaz (Open ERP)

[FIX] minor changes.

3227. By Xavier (Open ERP)

[IMP] try to ensure test removal from <email address hidden> won't break

3228. By Chirag Patel (OpenERP)

[FIX] Set position for contextmenu.

3229. By Sananaz (Open ERP)

[FIX] Fixed close error window.

3230. By Vaibhav Darji

[FIX] Save_filter in lightbox, changes related to filters.

3231. By Kunal Chavda

[FIX] Display blank axis graph when no data.

3232. By Vaibhav Darji

[FIX] Fixed Image widget issue.

3233. By Jiten (OpenERP)

[IMP] Minor change (Removed console log line from group by search filter).

3234. By Navrang Oza

[FIX] Fixed width problem for search view.

3235. By Navrang Oza

[FIX] Search filter button's icons aligned centered.

3236. By Sananaz (Open ERP)

[FIX] Fixed css for login page.

3237. By Kunal Chavda

[FIX] Fixed Form view will not open if not defined.

3238. By Vaibhav Darji

[FIX] Edit only when editable.

3239. By Xavier (Open ERP)

[REV] restrictions of list views to editable only as they break selection of items in relation fields

3240. By Xavier (Open ERP)

[REM] unused styles for login page

3241. By Xavier (Open ERP)

[IMP] remove unused argument on common.error

3242. By Xavier (Open ERP)

[IMP] clarify error message in case of socket error during RPC execute call

3243. By Xavier (Open ERP)

[REV] incorrect commit 3240

3244. By Navrang Oza

[FIX] Removed icons from tree view.

3245. By Julien Thewys

[FIX] Uses os.path.sep instead of '/' to make it work also on Windows.

3246. By Vaibhav Darji

[REM] Removed CLEAR button from search view.

3247. By Vaibhav Darji

[FIX] Minor changes for save filter.

3248. By Navrang Oza

[FIX] Removed unnecessary spaces (Put spyglass inside textbox for m2o).

3249. By Jiten (OpenERP)

[FIX] Improved Help screen (Removed extra spaces between description and graph).

3250. By Xavier (Open ERP)

[FIX] display of listgrid loading throbber

3251. By Jiten (OpenERP)

[IMP] Set the link for online help page for object/model.

3252. By Xavier (Open ERP)

[IMP] Use os.path.split rather than str.split for a path-extraction task

3253. By Xavier (Open ERP)

[IMP] simplify handling of saving filters a bit

3254. By Xavier (Open ERP)

[FIX] JS error in some popups in non-Firefox browsers: executing $.get(0) even when no node to get

3255. By Vaibhav Darji

[FIX] Changes for listgroup sorting.

3256. By Vaibhav Darji

[MERGE] validation inline editable list and o2m.

3257. By Vaibhav Darji

[FIX] Minor change.

3258. By Vaibhav Darji

[FIX] Assign id to imp form.

3259. By Jiten (OpenERP)

[IMP] Improved top-right buttons.

3260. By Jiten (OpenERP)

[IMP] Minor change in last commite(top-right buttons).

3261. By Navrang Oza

[IMP] Improved fields size (Fix the width of widgets).

3262. By Navrang Oza

[FIX] Fixed fields size for listgrid.

3263. By Chirag Patel (OpenERP)

[FIX] Fixed conflicted calendar.js.

3264. By Jiten (OpenERP)

[IMP] Improved looks of Help screen.

3265. By Sananaz (Open ERP)

[IMP] Improve database all errors in popups.

3266. By Vaibhav Darji

[FIX] Activate group by for saved filters.

3267. By Chirag Patel (OpenERP)

[FIX] fixed language problem for calender.

3268. By Navrang Oza

[FIX] Handled unknown locale.

3269. By Vaibhav Darji

[FIX] Treegrid width for import/export.

3270. By Navrang Oza

[FIX] Improved binary widget size.

3271. By Sananaz (Open ERP)

[Fix] Fixed m2o problem (google chrome).

3272. By Xavier (Open ERP)

[REV] <email address hidden> as it doesn't fix the underlying issue with m2ms

* Breaks relation-removal for m2ms (deleting by clicking on X sign doesn't work anymore, record is back if you reload)
* Doesn't fix selecting multiple records and going through the [DELETE] listview button

3273. By Navrang Oza

[FIX] Minor changes for safari.

3274. By Chirag Patel (OpenERP)

[Fix] Remove extra space from save as filter.

3275. By Xavier (Open ERP)

[FIX] revert the revert, had misunderstood m2m relations lifecycle

3276. By Sananaz (Open ERP)

[FIX] Fixed many2many delete operation.

3277. By Kunal Chavda

[IMP] Improved font-size for buttons.

3278. By Vaibhav Darji

[FIX] Activate search filters for graph.

3279. By Sananaz (Open ERP)

[FIX] Fixed many2one popup search view.

3280. By Jiten (OpenERP)

[IMP] Imroved images of group headers (Group by, Filters,Hide columns, etc.)

3281. By Kunal Chavda

[IMP] Improved layout of buttons.

3282. By Sananaz (Open ERP)

[FIX] Fixed lable style for custom filter.

3283. By Xavier (Open ERP)

[FIX] Fixed conflicts between sidebar attachments and document attachment.

3284. By Xavier (Open ERP)

[REM] unused local variables

3285. By Xavier (Open ERP)

[REM] unused import and incorrect module docstring

3286. By Xavier (Open ERP)

[IMP] 'fix' multiple overridings of a base controller

All objects being indexed by the same key will now be made into an inheritance hierarchy. This lets developers extend existing objects (mainly controller) in-place without another developer extending the same object losing their own work.

WARNING: deeper inheritance trees (where other objects inherit from the one being extended in-place) are *not* handled, extenders will *not* be seen by children classes

3287. By Jiten (OpenERP)

[IMP] Improved search view to set padding.

3288. By Amit Mendapara

[FIX] cookie issue (login form).

3289. By Amit Mendapara

[FIX] Translation issue (bug #599438)
[FIX] ADDONS_PATH issue (egg install)

3290. By Amit Mendapara

[FIX] CSRF vulnerability (bug #632935)

3291. By Chirag Patel (OpenERP)

[FIX] Add view log popup to fancybox.

3292. By Chirag Patel (OpenERP)

[FIX] code optimized for view log.

3293. By Xavier (Open ERP)

[IMP] style of Search.do_filter_sc
Remove unused variables
use dict litteral
formatting

3294. By Jiten (OpenERP)

[FIX] Improved login page.

3295. By Jiten (OpenERP)

[IMP] Button/link for OpenERP warranty in help page.

3296. By Vaibhav Darji

[FIX] Fixed search filters criteria.

3297. By Jiten (OpenERP)

[FIX] Set scrolling direction for main menu items.

3298. By Navrang Oza

[IMP] Improved error box, and error messages.

3299. By Sananaz (Open ERP)

[FIX] Fixed m2o autocomplete.

3300. By Jiten (OpenERP)

[FIX] Improved visibility of pushed buttons.

3301. By Vaibhav Darji

[FIX] at end of wizard do not reload parent.

3302. By Navrang Oza

[IMP] Left alignment fixing for fields, widgets.

3303. By Navrang Oza

[FIX] Some minor changes for alignment.

3304. By Amit Mendapara

[FIX] python egg filename

3305. By Navrang Oza

[FIX] Minor changes for button visibility in search view.

3306. By Amit Mendapara

[FIX] package name issues (bug #628835)

3307. By Vaibhav Darji

[FIX] Group by issue when swith view.

3308. By Xavier (Open ERP)

[IMP] a few comments & docstrings

3309. By Xavier (Open ERP)

[IMP] cleanup filter button styles a bit

3310. By Vaibhav Darji

[FIX] Fix for group by when swith.

3311. By Navrang Oza

[FIX] Minor changes for left-alignment.

3312. By Vaibhav Darji

[FIX] Fixed validation for form when create new records.

3313. By Sananaz (Open ERP)

[FIX] Fixed problem.

3314. By Jiten (OpenERP)

[IMP] Improved looks of search filters.

3315. By Chirag Patel (OpenERP)

[IMP] Delete operation for o2m.

3316. By Vaibhav Darji

[FIX] Minor changes for group_by.

3317. By Amit Mendapara

[FIX] win32 installer

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Finally came around to fixing those issues, could you check again?

3318. By Vaibhav Darji

[FIX] Minor changes for filte button(icon only).

3319. By Sananaz (Open ERP)

[FIX] Fixed updated ids problem for listview.

3320. By Jiten (OpenERP)

[IMP] Improved
- Set alignment of labels and fields.
- adjust width(header, main menu).

3321. By Chirag Patel (OpenERP)

[FIX] Fixed edit for Web Modules.

3322. By Jiten (OpenERP)

[IMP] Minor change on set label.

3323. By Sananaz (Open ERP)

[FIX] Fixed regression of o2m, m2m for listview.

Revision history for this message
Navrang Oza (noz-tiny) wrote :

From my last comment, the 100% width problem is solved now for header and all.
Thanks for that.

But for this branch, its needed to check with latest trunk code.
So if latest trunk code and this current branch will merged then layout problem will be solved.
But need to check with trunk.

Thanks.

3324. By Xavier (Open ERP)

[FIX] in list views, buttons [DELETE] and [EDIT] should not be available when not editable

3325. By Xavier (Open ERP)

[IMP] simplify conditional by applying DeMorgan's law

3326. By Xavier (Open ERP)

[REM] unused imports

3327. By Navrang Oza

[FIX] CSRF vulnerability (bug #632935).

3328. By Navrang Oza

[FIX] Fixed preference width problem.

3329. By Xavier (Open ERP)

[FIX] Fixed saved blank record when save parent for one2many.

3330. By Xavier (Open ERP)

[IMP] tentative pretty major reorganization of the validators import in order to try and avoid systemic import failures due to a bunch of undebuggable errors related to Python getting lost in the crap.

* Split of validators, no more which a third module then star-imports itself
* Formencode validators are formencode validators, they are not openobject or openerp validators
* Remove unneeded layers of packages, just use modules when possible
* Add an __all__ spec to openobject.validators
* Remove redundant/unneeded imports

3331. By Vaibhav Darji

[FIX] set target to form.

3332. By Vaibhav Darji

[REV] Revert revision 3331 as its broken configuration wizard.

3333. By Sananaz (Open ERP)

[FIX] Fixed boolean clicked event.
- Code optimization for form_state.

3334. By Sananaz (Open ERP)

[FIX] Fixed pagination problem.

3335. By Vaibhav Darji

[FIX] Target for openERP link.

3336. By Jiten (OpenERP)

[FIX] Improved CSRF vulnerability (bug #632935).

3337. By Navrang Oza

[FIX] Removed unnecessary header creation in listgrid.

3338. By Vaibhav Darji

[FIX] Domain for graphs reload.

3339. By Sananaz (Open ERP)

[ADD] JSONP support in @expose renderer

Now possible to use an output format of 'jsonp' as well as the previous 'json' and 'html'.

Useful when fetching big to huge amounts of JSON data as jquery does json validation via regexes and those can take more stack space than firefox allows, generating an error

3340. By Xavier (Open ERP)

[FIX] firefox/jquery combination error when loading big (>500 elements) listgrids, firefox would run out of stack space

Move ListView.reload moved to jsonp from original json to avoid jquery's validation and gain in speed a bit

3341. By Xavier (Open ERP)

[MERGE] in-place extension of controllers and widgets, edition of templates (via editor preprocessors, text-based) in web addons

3342. By Sananaz (Open ERP)

[FIX] Fixed invisible on attrs change.

3343. By Xavier (Open ERP)

[FIX] forgot to add the meta.py module in the just-merged branch

3344. By Xavier (Open ERP)

[ADD] mark_only parameter to @expose for overriding of exposed controller methods (exposure doesn't get inherited)

3345. By Xavier (Open ERP)

[FIX] indentation and probably some line-endings in _root.py

3346. By Chirag Patel (OpenERP)

[FIX] Fixed fields issue for group by.

3347. By Jiten (OpenERP)

[IMP] Improved search views, hover on foldable goups to change Text background.

3348. By Jiten (OpenERP)

[IMP] Minor change in last commite (forget to remove /span).

3349. By Vaibhav Darji

[FIX] Fixed axis keys to ustr for graphs.

3350. By Sananaz (Open ERP)

[FIX] Fixed attrs on buttons.

3351. By Vaibhav Darji

[FIX] m2o search name property.

3352. By Vaibhav Darji

[FIX] Minor changes for groupby(when no groupuby display blank).

3353. By Sananaz (Open ERP)

[FIX] Speed Improvement and Report actions to follow data dictionary instead of id.

3354. By Sananaz (Open ERP)

[FIX] Fixed action when data is empty.

3355. By Vaibhav Darji

[FIX] Target to new for reports.

3356. By Xavier (Open ERP)

[IMP] only display known attachment typers (binary & url) in sidebar

3357. By Jiten (OpenERP)

[IMP] Improved label attributes('for' and 'kind').

3358. By Jiten (OpenERP)

[FIX] Change href(link) for Modules and Scrrencasts in About page.

3359. By Vaibhav Darji

[IMP] Improvements for reports.

3360. By Vaibhav Darji

[ADD] Forgot to add report template.

3361. By Xavier (Open ERP)

[IMP] handling of widget labels display: make labels into widgets themselves and have them self-display to simplify code of frame.mako

3362. By Xavier (Open ERP)

[ADD] custom label widget for Range widgets (two-fields composites -> InputWidgetLabel doesn't work)

3363. By Xavier (Open ERP)

[ADD] very basic demonstration of the extensions API to the web client

3364. By Xavier (Open ERP)

[IMP] try to simplify (& clarify) addons management code a bit

3365. By Xavier (Open ERP)

[FIX] missing attribute to addons.Node

3366. By Xavier (Open ERP)

[REM] unused local variable

3367. By Xavier (Open ERP)

[REM] unused static return value in addons.load_addons

3368. By Sananaz (Open ERP)

[FIX] Fixed addClass for readonly.

3369. By Vaibhav Darji

[IMP] Improved binary, image widget.

3370. By Vaibhav Darji

[ADD] Missing binary js function.

3371. By Vaibhav Darji

[FIX] Fixes for new o2m record.

3372. By Vaibhav Darji

[FIX] Fix current id for o2m when save.

3373. By Xavier (Open ERP)

[FIX] if xhr.responseText not available in doLoadingSuccess (why?), use data instead

3374. By Xavier (Open ERP)

[IMP] bump RPC timeout from 120s to 450s in order to avoid timeout errors on long RPC requests (e.g. installation of a great number of addons via the applications installer)

3375. By Xavier (Open ERP)

[IMP] get the RPC timeout from the config file instead of hardcoding it

3376. By Sananaz (Open ERP)

- [FIX] Fixed button action for ListView.
- Code optimization.

3377. By Chirag Patel (OpenERP)

[FIX] Fixed left alignment for form title.

3378. By Kunal Chavda

[FIX] Fixed average calculation for groupby.

3379. By Jiten (OpenERP)

[IMP] Improved: Error message display in lightbox.

3380. By Vaibhav Darji

[FIX] Fix text issues for graph(increase width).

3381. By Xavier (Open ERP)

[FIX] simplify and cleanup pooler (remove auto_create), remove finalization

3382. By Xavier (Open ERP)

[REM] widget_wiki addon, transferred to the wiki/ server module

3383. By Xavier (Open ERP)

[ADD] downloading and unpacking of web addons from server.

Problem: because we change content in /addons, CherryPy's autoreloader restarts the server all the time.
Also, restart_pooler should manage the checks/downloads, not the other way around (probably)

3384. By Xavier (Open ERP)

[IMP] if no installed server modules with a web component, bail out immediately

3385. By Xavier (Open ERP)

[IMP] only download addons we don't already have, in order to avoid CherryPy's systematic reloading

3386. By Jiten (OpenERP)

[IMP] Changes in revision 3379.

3387. By Xavier (Open ERP)

[FIX] regression: view button icon on the wrong button

3388. By Xavier (Open ERP)

[FIX] regression with styling of calendar view button

3389. By Xavier (Open ERP)

[FIX] get_registered_views has to instantiate the views it fetches from the pooler itself or sort is random

3390. By Xavier (Open ERP)

[IMP] remove unused parameter in definition of displayed view buttons

3406. By Xavier (Open ERP)

[FIX] width of thin filters

3407. By Xavier (Open ERP)

[FIX] accordion folder toggle disappearing

3408. By Xavier (Open ERP)

[REM] unused CSS

3409. By Xavier (Open ERP)

[FIX] header width and leftover scrollbar in form views by moving the whole layout to tables, and removing .item from non-TinyInputWidget widgets

3410. By Xavier (Open ERP)

[FIX] width issue on calendar view

3411. By Xavier (Open ERP)

[FIX] removed InputWidgetLabel a few revisions ago during rebase

3412. By Xavier (Open ERP)

[FIX] stray brace breaking parts of the layout

3413. By Xavier (Open ERP)

[IMP] filter_icon buttons icon centering on their background in Firefox

Preview Diff

Empty