Merge lp:~xmo-deactivatedaccount/openerp-client-lib/trunk into lp:openerp-client-lib

[Xavier (Open ERP)]

Bunch o' fixes:

* Added links to the homepage and code repo in the module docstring
* Fixed typos, docstring location errors, logging calls, noops, an overly complex loop and too broad exception handlers

[lp:~xmo-deactivatedaccount/openerp-client-lib/trunk]

34. By Xavier (Open ERP) on 2011-09-14

[FIX] typo

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Fixed a code typo in an iteration

=== modified file 'openerplib/main.py'
--- openerplib/main.py	2011-09-14 09:52:52 +0000
+++ openerplib/main.py	2011-09-14 11:51:43 +0000
@@ -32,6 +32,9 @@
 
 """
 OpenERP Client Library
+
+Home page: http://pypi.python.org/pypi/openerp-client-lib
+Code repository: https://code.launchpad.net/~niv-openerp/openerp-client-lib/trunk
 """
 
 import xmlrpclib
@@ -40,14 +43,12 @@
 
 try:
     import cPickle as pickle
-    pickle.__name__
-except:
+except ImportError:
     import pickle
 
 try:
     import cStringIO as StringIO
-    StringIO.__name__
-except:
+except ImportError:
     import StringIO
 
 _logger = logging.getLogger(__name__)
@@ -102,7 +103,7 @@
         self.faultString = faultString
         self.args = (faultCode, faultString)
 
-class NetRPC:
+class NetRPC(object):
     """
     Low level class for NetRPC protocol.
     """
@@ -191,7 +192,7 @@
         socket.disconnect()
         return result
 
-class Service:
+class Service(object):
     """
     A class to execute RPC calls on a specific service of the remote server.
     """
@@ -215,13 +216,13 @@
             """
             self.__logger.debug('args: %r', args)
             result = self.connector.send(self.service_name, method, *args)
-            self.__logger.debug('result: %r' % result)
+            self.__logger.debug('result: %r', result)
             return result
         return proxy
 
 class Connection(object):
     """
-    A class to represent a connection with authentification to an OpenERP Server.
+    A class to represent a connection with authentication to an OpenERP Server.
     It also provides utility methods to interact with the server more easily.
     """
     __logger = _getChildLogger(_logger, 'connection')
@@ -263,8 +264,8 @@
         
     def check_login(self, force=True):
         """
-        Checks that the login information is valid. Throws an AuthentificationError if the
-        authentification fails.
+        Checks that the login information is valid. Throws an AuthenticationError if the
+        authentication fails.
 
         :param force: Force to re-check even if this Connection was already validated previously.
         Default to True.
@@ -273,46 +274,46 @@
             return
         
         if not self.database or not self.login or self.password is None:
-            raise AuthentificationError("Creditentials not provided")
+            raise AuthenticationError("Creditentials not provided")
         
         self.user_id = self.get_service("common").login(self.database, self.login, self.password)
         if not self.user_id:
-            raise AuthentificationError("Authentification failure")
-        self.__logger.debug("Authentified with user id %s" % self.user_id)
-    
-    """
-    Returns a Model instance to allow easy remote manipulation of an OpenERP model.
-    
-    :param model_name: The name of the model.
-    """
+            raise AuthenticationError("Authentication failure")
+        self.__logger.debug("Authenticated with user id %s", self.user_id)
+    
     def get_model(self, model_name):
+        """
+        Returns a Model instance to allow easy remote manipulation of an OpenERP model.
+
+        :param model_name: The name of the model.
+        """
         return Model(self, model_name)
 
-    """
-    Returns a Service instance to allow easy manipulation of one of the services offered by the remote server.
-    Please note this Connection instance does not need to have valid authenfication information since authentification
-    is only necessary for the "object" service that handles models.
-
-    :param service_name: The name of the service.
-    """
     def get_service(self, service_name):
+        """
+        Returns a Service instance to allow easy manipulation of one of the services offered by the remote server.
+        Please note this Connection instance does not need to have valid authentication information since authentication
+        is only necessary for the "object" service that handles models.
+
+        :param service_name: The name of the service.
+        """
         return Service(self.connector, service_name)
 
-class AuthentificationError(Exception):
+class AuthenticationError(Exception):
     """
-    An error thrown when an authentification to an OpenERP server failed.
+    An error thrown when an authentication to an OpenERP server failed.
     """
     pass
 
 class Model(object):
     """
     Useful class to dialog with one of the models provided by an OpenERP server.
-    An instance of this class depends on a Connection instance with valid authenfication information.
+    An instance of this class depends on a Connection instance with valid authentication information.
     """
 
     def __init__(self, connection, model_name):
         """
-        :param connection: A valid Connection instance with correct authentification information.
+        :param connection: A valid Connection instance with correct authentication information.
         :param model_name: The name of the model.
         """
         self.connection = connection
@@ -341,10 +342,10 @@
             if method == "read":
                 if isinstance(result, list) and len(result) > 0 and "id" in result[0]:
                     index = {}
-                    for i in xrange(len(result)):
-                        index[result[i]["id"]] = result[i]
+                    for r in result:
+                        index[r['id']] = r
                     result = [index[x] for x in args[0]]
-            self.__logger.debug('result: %r' % result)
+            self.__logger.debug('result: %r', result)
             return result
         return proxy