Merge lp:~xmacex/ubuntu/raring/modemmanager/ignore-arduino-lilypad-usb into lp:ubuntu/raring/modemmanager

Proposed by Mace on 2013-03-11
Status: Work in progress
Proposed branch: lp:~xmacex/ubuntu/raring/modemmanager/ignore-arduino-lilypad-usb
Merge into: lp:ubuntu/raring/modemmanager
Diff against target: 27 lines (+9/-0)
2 files modified
debian/changelog (+6/-0)
src/77-mm-usb-device-blacklist.rules (+3/-0)
To merge this branch: bzr merge lp:~xmacex/ubuntu/raring/modemmanager/ignore-arduino-lilypad-usb
Reviewer Review Type Date Requested Status
James Page Needs Fixing on 2013-03-25
Ubuntu branches 2013-03-11 Pending
Review via email:

Description of the change

Hi, i added Arduino LilyPad USB as one of the devices modemmanager should ignore. This is my first ever bugfix for Ubuntu, so i hope i made everything correctly after reading the bugfixing documentation. Cheers!

To post a comment you must log in.
James Page (james-page) wrote :

Hi Mace

Thanks for taking the time to propose this fix for Ubuntu.

As this is your first bugfix now is a great time to learn about how the 'source format' of a Debian package works.

This package is source format 3.0 (quilt) (see debian/source/format); as a result when we do fixes in packaging, they are applied as patches to the original source code as part of the package build process, rather than applying the fixes directly to the upstream source code.

This package already has a number of such fixes - see debian/patches/*.

Have a read of - - it will walk you through how to prepare your fix as a quilt patch.



James Page (james-page) :
review: Needs Fixing

Unmerged revisions

37. By Mace on 2013-03-11

src/77-mm-usb-device-blacklist.rules: included Arduino LilyPad USB as a device modemmanager should ignore (LP: #1153632)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-01-28 11:24:42 +0000
3+++ debian/changelog 2013-03-11 15:45:25 +0000
4@@ -1,3 +1,9 @@
5+modemmanager ( UNRELEASED; urgency=low
7+ * src/77-mm-usb-device-blacklist.rules: included Arduino LilyPad USB as a device modemmanager should ignore (LP: #1153632)
9+ -- Mace Ojala <mace@mace-901> Mon, 11 Mar 2013 17:38:51 +0200
11 modemmanager ( raring; urgency=low
13 * debian/patches/linux-default-usb-id.patch: blacklist the USB-Gadget default
15=== modified file 'src/77-mm-usb-device-blacklist.rules'
16--- src/77-mm-usb-device-blacklist.rules 2013-01-28 11:24:42 +0000
17+++ src/77-mm-usb-device-blacklist.rules 2013-03-11 15:45:25 +0000
18@@ -81,6 +81,9 @@
19 ATTRS{idVendor}=="0403", ATTRS{idProduct}=="6001", ENV{ID_MM_DEVICE_IGNORE}="1"
20 ATTRS{idVendor}=="03eb", ATTRS{idProduct}=="204b", ENV{ID_MM_DEVICE_IGNORE}="1"
21 ATTRS{idVendor}=="2341", ENV{ID_MM_DEVICE_IGNORE}="1"
22+## Arduino LilyPad USB
23+ATTRS{idVendor}=="1b4f", ATTRS{idProduct}=="9207", ENV{ID_MM_DEVICE_IGNORE}="1"
24+ATTRS{idVendor}=="1b4f", ATTRS{idProduct}=="9208", ENV{ID_MM_DEVICE_IGNORE}="1"
26 # Netchip Technology, Inc. Linux-USB Serial Gadget (CDC ACM mode)
27 ATTRS{idVendor}=="0525", ATTRS{idProduct}=="a4a7", ENV{ID_MM_DEVICE_IGNORE}="1"


People subscribed via source and target branches

to all changes: