Merge lp:~xiangxw5689/synapse-project/synapse-project into lp:synapse-project

Proposed by xiangxw on 2014-01-17
Status: Needs review
Proposed branch: lp:~xiangxw5689/synapse-project/synapse-project
Merge into: lp:synapse-project
Diff against target: 17 lines (+6/-0)
1 file modified
src/core/desktop-file-service.vala (+6/-0)
To merge this branch: bzr merge lp:~xiangxw5689/synapse-project/synapse-project
Reviewer Review Type Date Requested Status
xiangxw (community) Approve on 2014-01-17
Rizal Muttaqin 2014-03-03 Pending
Review via email: mp+202037@code.launchpad.net

Description of the change

Use both english name and locale name for application name if they are diffent

To post a comment you must log in.
xiangxw (xiangxw5689) wrote :

This merge will not affect users without a locale language.
It make synapse more convenient for users with a locale language.

review: Approve

Unmerged revisions

514. By xiangxw on 2014-01-17

Use both english name and locale name for application name if they are diffent

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/core/desktop-file-service.vala'
2--- src/core/desktop-file-service.vala 2012-10-14 23:34:33 +0000
3+++ src/core/desktop-file-service.vala 2014-01-17 04:10:18 +0000
4@@ -130,7 +130,13 @@
5 throw new DesktopFileError.UNINTERESTING_ENTRY ("Unable to create AppInfo");
6 }
7
8+ var name_en = keyfile.get_string(GROUP, "Name");
9 name = app_info.get_name ();
10+ if (name_en != name) // Use both english name and locale name if they are diffent
11+ {
12+ name += "(" + name_en + ")";
13+ }
14+
15 exec = app_info.get_commandline ();
16 if (exec == null)
17 {