Merge ~xavpaice/charm-nagios:pagerduty-defaults into ~nagios-charmers/charm-nagios:master

[Xav Paice]

Change pagerduty_notification_levels default

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[James Hebden (ec0)]

Approving from a technical perspective, and from a usage perspective.

For two reasons I believe not sending warnings to PagerDuty makes sense as a default:
- Paging via PagerDuty for warnings is orthogonal to the meaning and intention of warnings in Nagios, which are intended for reflecting opportunities for proactive work to prevent future incidents.
- With the unidirectional integration we currently use for PagerDuty in the charm, warnings are not created with low-priority associated with them in PagerDuty, instead being given the exact same characteristics as a critical-initiated page. This leads to pager spam of most heinous proportions.

One additional idea would be to also implement support in the bundled integration to map warning pages to low-importance pages in PagerDuty. We currently lack this support, so for now, this MP gets a +1 from me.

I have also raised https://bugs.launchpad.net/nagios-charm/+bug/1834818 to cover the mapping of Nagios warnings to low-urgency PagerDuty events as a wishlist item.

review: Approve

[Jeremy Lounder (jldev)]

This is a recent enough configuration option, I believe it is acceptable to change the default.

review: Approve (+1)

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 9aa1d8465582cb44e65e4b227ae3c9c83d063132

diff --git a/config.yaml b/config.yaml
index 5aff8c9..cc7102b 100644
--- a/config.yaml
+++ b/config.yaml
@@ -171,12 +171,11 @@ options:
             to report warning at 5.0, 4.0 and 3.0 averages, critical at 10.0, 
             6.0 and 4.0.
     pagerduty_notification_levels:
-        default: w,u,c,r
+        default: u,c,r
         type: string
         description: |
             A string to use for the service_notification_options in the
-            pagerduty contact configuration.  Remove w to avoid paging for
-            warning events.
+            pagerduty contact configuration.  Add w to page for warning events.
     check_timeout:
         default: 10
         type: int