Merge ~xavpaice/charm-hw-health:lp1855095 into ~nagios-charmers/charm-hw-health:master

[Xav Paice]

remove HP from supported vendors as it's not actually supported yet

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Paul Goins (vultaire)]

I think this basically works.

Arguably I'd suggest simply removing the lines and adding them back in in the future if support is ever properly added, so as to remove cruft. It depends on how likely we think that support will be added in the future.

It might be worth adding a comment to the code with an explanation, but at the same time, "git blame" can be used to find the commit that these were commented in, and the commit message can provide this explanation.

However, I would strongly suggest that we mention lp#1855095 either in the commit message or in a comment, as that won't be readily viewable via git after this gets merged.

review: Needs Fixing

[Xav Paice (xavpaice)]

commit message updated - I've left the code there since the addition is on the roadmap and it'll save some time looking up vendor strings in the future.

[Paul Goins (vultaire)]

Thanks; approved.

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 9344567906e67f6cc1e54dbc7a0d0cfbd067ce4e

diff --git a/src/lib/hwhealth/discovery/supported_vendors.py b/src/lib/hwhealth/discovery/supported_vendors.py
index 3dc9694..8dc588e 100644
--- a/src/lib/hwhealth/discovery/supported_vendors.py
+++ b/src/lib/hwhealth/discovery/supported_vendors.py
@@ -18,9 +18,9 @@ SUPPORTED_VENDORS = {
         'NVMe SSD Controller SM961/PM961': tools.Nvme,
         'NVMe SSD Controller 172Xa/172Xb': tools.Nvme,
     },
-    'Hewlett-Packard Company': {
-        'Smart Array Gen9 Controllers': tools.HP,
-    }
+    # 'Hewlett-Packard Company': {
+    #     'Smart Array Gen9 Controllers': tools.HP,
+    # }
 }
 
 SUPPORTED_DRIVERS = {