Merge ~xavpaice/charm-telegraf:add_juju_model_uuid into charm-telegraf:master

Proposed by Xav Paice
Status: Merged
Approved by: James Troup
Approved revision: 7c9a9242303a380df75971db8e3b1dfacada0ceb
Merged at revision: c4a8e0688eeaef3a0fd432ac1550dc23a6d5a050
Proposed branch: ~xavpaice/charm-telegraf:add_juju_model_uuid
Merge into: charm-telegraf:master
Diff against target: 26 lines (+4/-0)
2 files modified
src/reactive/telegraf.py (+1/-0)
src/tests/unit/test_telegraf.py (+3/-0)
Reviewer Review Type Date Requested Status
Celia Wang Approve
Haw Loeung +1 Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Needs Fixing
BootStack Reviewers Pending
Review via email: mp+407421@code.launchpad.net

Commit message

Add juju_model_uuid to tags

Adds the juju_model_uuid tag to metrics, to match up with the metadata provided in the charms interfacing with the prometheus-k8s charm.

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve (+1)
Revision history for this message
Celia Wang (ziyiwang) wrote :

lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision c4a8e0688eeaef3a0fd432ac1550dc23a6d5a050

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/reactive/telegraf.py b/src/reactive/telegraf.py
2index ecbbf57..137d4d8 100644
3--- a/src/reactive/telegraf.py
4+++ b/src/reactive/telegraf.py
5@@ -712,6 +712,7 @@ def configure_telegraf(): # noqa: C901
6 tags_dict["juju_unit"] = get_remote_unit_name().replace("/", "-")
7 try:
8 tags_dict["juju_model"] = hookenv.model_name()
9+ tags_dict["juju_model_uuid"] = hookenv.model_uuid()
10 except KeyError:
11 pass # support older Juju 1.x deploys
12 # Parse juju-configured tags, which can override the 3 juju_* defined above
13diff --git a/src/tests/unit/test_telegraf.py b/src/tests/unit/test_telegraf.py
14index 55eae97..8379987 100644
15--- a/src/tests/unit/test_telegraf.py
16+++ b/src/tests/unit/test_telegraf.py
17@@ -66,6 +66,9 @@ UNIT_TESTS_DATA_DIR = os.path.join(UNIT_TESTS_DIR, "data")
18 def setup(monkeypatch, tmpdir):
19 monkeypatch.setitem(os.environ, "JUJU_UNIT_NAME", "telegraf/0")
20 monkeypatch.setitem(os.environ, "JUJU_MODEL_NAME", "telegraf-test-model")
21+ monkeypatch.setitem(
22+ os.environ, "JUJU_MODEL_UUID", "abcdef12-0000-0000-0000-abcdabcdabcd"
23+ )
24 monkeypatch.setattr(telegraf, "get_remote_unit_name", lambda: "remote-unit/0")
25 # mock this to avoid permission errors
26 monkeypatch.setattr(telegraf, "update_sysstat_config_with_sdac_xall", lambda: True)

Subscribers

People subscribed via source and target branches

to all changes: