Merge ~xavpaice/charm-openstack-service-checks/+git/charm-openstack-service-checks:lp1852549 into ~canonical-bootstack/charm-openstack-service-checks:master

Proposed by Xav Paice
Status: Merged
Approved by: Celia Wang
Approved revision: 900cb3bfd0b84886ab489228ea1b5b475e3e91e3
Merged at revision: a6614cf6ea15e4dc605cc8e4c870c7621a7064e2
Proposed branch: ~xavpaice/charm-openstack-service-checks/+git/charm-openstack-service-checks:lp1852549
Merge into: ~canonical-bootstack/charm-openstack-service-checks:master
Diff against target: 12 lines (+1/-0)
1 file modified
reactive/openstack_service_checks.py (+1/-0)
Reviewer Review Type Date Requested Status
Celia Wang Approve
Review via email: mp+379364@code.launchpad.net

This proposal supersedes a proposal from 2020-02-17.

Commit message

Fix lint error ./reactive/openstack_service_checks.py:213:1: E302 expected 2 blank lines, found 1

To post a comment you must log in.
Revision history for this message
Xav Paice (xavpaice) wrote : Posted in a previous version of this proposal
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote : Posted in a previous version of this proposal

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote : Posted in a previous version of this proposal

Unable to determine commit message from repository - please click "Set commit message" and enter the commit message manually.

Revision history for this message
Celia Wang (ziyiwang) wrote : Posted in a previous version of this proposal

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote : Posted in a previous version of this proposal

Change has no commit message, setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote : Posted in a previous version of this proposal

Change successfully merged at revision 23c1be5d802f6d27068d1219c1267a309fd5676c

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Celia Wang (ziyiwang) wrote :

Ack.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision a6614cf6ea15e4dc605cc8e4c870c7621a7064e2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/openstack_service_checks.py b/reactive/openstack_service_checks.py
2index 1d19af2..a7e2666 100644
3--- a/reactive/openstack_service_checks.py
4+++ b/reactive/openstack_service_checks.py
5@@ -210,6 +210,7 @@ def configure_nrpe_endpoints():
6 except OSCEndpointError as error:
7 hookenv.log(error)
8
9+
10 @when('identity-notifications.available.updated')
11 def endpoints_changed():
12 clear_flag('openstack-service-checks.endpoints.configured')

Subscribers

People subscribed via source and target branches