Merge ~xavpaice/charm-openstack-service-checks/+git/charm-openstack-service-checks:keystonev3 into ~canonical-bootstack/charm-openstack-service-checks:master
Proposed by
Xav Paice
Status: | Merged |
---|---|
Approved by: | James Hebden |
Approved revision: | e079a5391d526f296da5224a958b5de316de1a59 |
Merge reported by: | Xav Paice |
Merged at revision: | e079a5391d526f296da5224a958b5de316de1a59 |
Proposed branch: | ~xavpaice/charm-openstack-service-checks/+git/charm-openstack-service-checks:keystonev3 |
Merge into: | ~canonical-bootstack/charm-openstack-service-checks:master |
Diff against target: |
107 lines (+47/-21) 2 files modified
reactive/service_checks.py (+40/-20) templates/nagios.novarc (+7/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Hebden (community) | Approve | ||
Review via email: mp+331394@code.launchpad.net |
To post a comment you must log in.
As discussed my only concern was the scoping the token to a domain and/or project may produce different results to the existing v2 code, which may have required additional logic to have the checks operate across multiple projects and domains.
Given this can be configured (and has been tested as such) to use the admin domain/project and this behaviour is not seen, LGTM.