~xavpaice/charm-nrpe:master-check-lacpdu

Branch merges

Propose for merging

Merged into ~nrpe-charmers/charm-nrpe:master at revision c31ece3f51895527e36da1f38cb4f0a2c2070e4c

Paul Goins: Approve on 2020-07-28

Joe Guo (community): Approve on 2020-07-27

Xav Paice (community): Needs Resubmitting on 2020-07-27

Canonical IS Reviewers: Pending requested 2020-07-26

Alvaro Uria: Pending requested 2020-07-26

Diff: 82 lines (+43/-6)

1 file modified

files/plugins/check_lacp_bond.py (+43/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

5d9c0f7... by Xav Paice on 2020-07-26

Lint and rebase fixes for LACPDU check

16c4760... by Andrea Ieri on 2020-07-24

[trivial] fix check_xfs_errors output typo (CRITCAL -> CRITICAL)

16a49f3... by Giuseppe Petralia on 2020-07-23

Fix linting. I had to disable black check for tests. Black wanted to reformat nrpe_tests converting some line to one line with length > 88 and
then flake8 was complaining as it is configured to check for max line length = 88. I had also disable syntax check for some older variants used in some nagios plugins as I didn't want to update code that has been in use for years with no issues.
I had also to increase flake8 max complexity to 14 because of:

./hooks/nrpe_helpers.py:370:5: C901 'SubordinateCheckDefinitions.__init__' is too complex (14)
./hooks/nrpe_utils.py:193:5: C901 'TolerantPortManagerCallback.__call__' is too complex (11)
./files/plugins/check_netlinks.py:26:1: C901 'check_iface' is too complex (13)

Reviewed-on: https://code.launchpad.net/~peppepetra86/charm-nrpe/+git/charm-nrpe/+merge/387825
Reviewed-by: Paul Goins <email address hidden>

14df450... by Giuseppe Petralia on 2020-07-23

Merge splitted string and fix some wrong indented lines

866cb62... by Giuseppe Petralia on 2020-07-22

Update Makefile to latest version.

d0af0ad... by Giuseppe Petralia on 2020-07-22

Fix linting

469e251... by Giuseppe Petralia on 2020-07-22

Add zaza functional tests

Reviewed-on: https://code.launchpad.net/~peppepetra86/charm-nrpe/+git/charm-nrpe/+merge/387528
Reviewed-by: Adam Dyess <email address hidden>
Reviewed-by: Alvaro Uria <email address hidden>

73df82c... by Giuseppe Petralia on 2020-07-22

Convert charmhelpers to git submodule

Reviewed-on: https://code.launchpad.net/~peppepetra86/charm-nrpe/+git/charm-nrpe/+merge/387525
Reviewed-by: Adam Dyess <email address hidden>
Reviewed-by: Alvaro Uria <email address hidden>

2d81fe2... by Giuseppe Petralia on 2020-07-22

Update git submodule command to pull latest changes from remote repos.
Remove lint from test target until linting is fixed.

3416670... by Giuseppe Petralia on 2020-07-21

Update build path to ./builds