dev/check_mtu : lp:~xavpaice/charm-nrpe : Git : Code : NRPE Charm

Get this branch:: git clone -b dev/check_mtu https://git.launchpad.net/~xavpaice/charm-nrpe

Only Xav Paice can upload to this branch. If you are Xav Paice please log in for upload directions.

Branch merges

Rejected for merging into ~nrpe-charmers/charm-nrpe:master

Xav Paice (community): Disapprove on 2020-10-22

Paul Goins: Approve on 2020-07-24

BootStack Reviewers: Pending (mr tracking; do not claim) requested 2022-06-11

BootStack Reviewers: Pending requested 2022-06-11

Canonical IS Reviewers: Pending requested 2020-07-23

Giuseppe Petralia: Pending requested 2020-07-23

Jeremy Lounder: Pending requested 2020-07-23

Branch information

Name:: dev/check_mtu

Repository:: lp:~xavpaice/charm-nrpe

Recent commits

eed1103... by Xav Paice on 2020-07-26

minor rework on check_mtu.py

Adjust some wording and layout in response to review feedback for the
check_mtu.py NRPE check.

2728bb5... by Xav Paice on 2020-07-24

update check_mtu arg syntax

6cf0d35... by Xav Paice on 2020-07-23

Address review comments from check_mtu.py

- some documentation fixes
- change get_mtu() to return an int()
- fix the output detail being reset for each interface

a70f663... by Xav Paice on 2020-07-23

update check_mtu.py plugin for one line of output

172acab... by David O Neill on 2020-04-08

MTU checker for neutron-gateway

16c4760... by Andrea Ieri on 2020-07-24

[trivial] fix check_xfs_errors output typo (CRITCAL -> CRITICAL)

16a49f3... by Giuseppe Petralia on 2020-07-23

Fix linting. I had to disable black check for tests. Black wanted to reformat nrpe_tests converting some line to one line with length > 88 and
then flake8 was complaining as it is configured to check for max line length = 88. I had also disable syntax check for some older variants used in some nagios plugins as I didn't want to update code that has been in use for years with no issues.
I had also to increase flake8 max complexity to 14 because of:

./hooks/nrpe_helpers.py:370:5: C901 'SubordinateCheckDefinitions.__init__' is too complex (14)
./hooks/nrpe_utils.py:193:5: C901 'TolerantPortManagerCallback.__call__' is too complex (11)
./files/plugins/check_netlinks.py:26:1: C901 'check_iface' is too complex (13)