logrotate-charm

Code review comment for ~xavpaice/charm-logrotated:bug_1833722

  1. Git
  2. lp:~xavpaice/charm-logrotated
  3. bug_1833722
  4. Merge into master
Revision history for this message
Alvaro Uria (aluria) wrote :

The change looks good. However, I think actions.py should call #!/usr/local/sbin/charm-env python3 so the active_venv() part is automatically done and "lib" is also included by default.

Other than that, +1

« Back to merge proposal