Merge ~xavpaice/charm-kubernetes-service-checks:add_plugins into charm-kubernetes-service-checks:master

Proposed by Xav Paice
Status: Merged
Merged at revision: 1128717329c64b871b3724200c62d57fbefc5907
Proposed branch: ~xavpaice/charm-kubernetes-service-checks:add_plugins
Merge into: charm-kubernetes-service-checks:master
Diff against target: 13 lines (+2/-0)
1 file modified
charmcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Linda Guo (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
BootStack Reviewers Pending
Review via email: mp+420518@code.launchpad.net

Commit message

Prime files/* in charmcraft.yaml

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Xav Paice (xavpaice) wrote :

Reason for this change is to include the NRPE plugin. Failure to have that in the charm resulted in `hook failed: "kube-control-relation-changed"`, that relation is tested in functional tests.

Revision history for this message
Linda Guo (lihuiguo) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charmcraft.yaml b/charmcraft.yaml
2index 462eab0..f0b71dd 100644
3--- a/charmcraft.yaml
4+++ b/charmcraft.yaml
5@@ -2,6 +2,8 @@ type: charm
6 parts:
7 charm:
8 charm-python-packages: [setuptools<58]
9+ prime:
10+ - files/*
11 bases:
12 - build-on:
13 - name: ubuntu

Subscribers

People subscribed via source and target branches

to all changes: