Merge ~xavpaice/charm-duplicity:bug/1925278 into charm-duplicity:master

[Xav Paice]

Add python-openstackclient for functests

Since b46f13ef113e690493364dabc87821699626d8e6 in zaza, if running tests
on an OpenStack cloud provider, each bundle test concludes with a
cleanup routine that needs the python-openstackclient package in
requirements.txt for the tox environment, plus the OS_ environment vars
exported/passed through such that the Openstack client actually works.
If these are not set, the test fails on the first bundle cleanup and
does not continue to the remaining bundles.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

A CI job is currently in progress. A follow up comment will be added when it completes.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

FAILED: Continuous integration, rev:7c4488f536e9d38827d59ad852088a1242bc8fb9

No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want jenkins to rebuild you need to trigger it yourself):
https://code.launchpad.net/~xavpaice/charm-duplicity/+git/charm-duplicity/+merge/401661/+edit-commit-message

https://jenkins.canonical.com/bootstack/job/lp-charm-duplicity-ci/1/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-unit/44/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/131/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-duplicity-ci/1//rebuild

review: Needs Fixing (continuous-integration)

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

PASSED: Continuous integration, rev:7c4488f536e9d38827d59ad852088a1242bc8fb9
https://jenkins.canonical.com/bootstack/job/lp-charm-duplicity-ci/2/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-unit/50/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/137/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-duplicity-ci/2//rebuild

review: Approve (continuous-integration)

[Paul Goins (vultaire)]

+1; needs another team member's +1 for merge.

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Tom Haddon (mthaddon)]

Abstaining, just claimed the review to take it off the canonical-is-reviewers dashboard, mergebot has been switched to add bootstack-reviewers for future MPs.

review: Abstain

diff --git a/src/tests/functional/requirements.txt b/src/tests/functional/requirements.txt
index 1dc40ce..d4871a5 100644
--- a/src/tests/functional/requirements.txt
+++ b/src/tests/functional/requirements.txt
@@ -2,3 +2,4 @@ flake8
 juju
 mock
 git+https://github.com/openstack-charmers/zaza.git#egg=zaza
+python-openstackclient
diff --git a/src/tox.ini b/src/tox.ini
index d75441e..8923ed4 100644
--- a/src/tox.ini
+++ b/src/tox.ini
@@ -21,6 +21,16 @@ passenv =
   NO_PROXY
   SNAP_HTTP_PROXY
   SNAP_HTTPS_PROXY
+  OS_REGION_NAME
+  OS_AUTH_VERSION
+  OS_AUTH_URL
+  OS_PROJECT_DOMAIN_NAME
+  OS_USERNAME
+  OS_PASSWORD
+  OS_PROJECT_ID
+  OS_USER_DOMAIN_NAME
+  OS_PROJECT_NAME
+  OS_IDENTITY_API_VERSION
 
 [testenv:lint]
 commands =