Merge lp:~xavi-garcia-mena/ubuntu/vivid/upower/percentages-power-off into lp:ubuntu/vivid/upower

Proposed by Xavi Garcia on 2016-03-23
Status: Rejected
Rejected by: Marc Deslauriers on 2016-04-12
Proposed branch: lp:~xavi-garcia-mena/ubuntu/vivid/upower/percentages-power-off
Merge into: lp:ubuntu/vivid/upower
Diff against target: 18 lines (+2/-2)
1 file modified
etc/UPower.conf (+2/-2)
To merge this branch: bzr merge lp:~xavi-garcia-mena/ubuntu/vivid/upower/percentages-power-off
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Disapprove on 2016-03-23
Ubuntu branches 2016-03-23 Pending
Review via email: mp+289935@code.launchpad.net

Commit message

Changed:
UsePercentageForPolicy=true
CriticalPowerAction=PowerOff

In config file, to use percentages and PowerOff action on battery critical level.

Description of the change

Changed:
UsePercentageForPolicy=true
CriticalPowerAction=PowerOff

In config file, to use percentages and PowerOff action on battery critical level.

To post a comment you must log in.
Alejandro J. Cura (alecu) wrote :

Looks good!

review: Approve
Alejandro J. Cura (alecu) wrote :

We decided against changing the default .conf, and instead will try to find a way to change this value on an override file.

review: Disapprove

Unmerged revisions

62. By Xavi Garcia on 2016-03-23

Changed to configuration to use percentages and to PowerOff when critical battery level is detected

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'etc/UPower.conf'
2--- etc/UPower.conf 2014-07-16 12:21:51 +0000
3+++ etc/UPower.conf 2016-03-23 16:02:38 +0000
4@@ -43,7 +43,7 @@
5 # is to use the time left, change to true to use the percentage, which
6 # should work around broken firmwares.
7 # default=false
8-UsePercentageForPolicy=false
9+UsePercentageForPolicy=true
10
11 # When UsePercentageForPolicy is true, the levels at which UPower will
12 # consider the battery low, critical, or take action for the critical
13@@ -88,4 +88,4 @@
14 #
15 # If HybridSleep isn't available, Hibernate will be used
16 # If Hibernate isn't available, PowerOff will be used
17-CriticalPowerAction=HybridSleep
18+CriticalPowerAction=PowerOff

Subscribers

People subscribed via source and target branches

to all changes: