lp:~xavi-garcia-mena/thumbnailer/art-downloader-interface

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:thumbnailer/devel at revision 122

PS Jenkins bot (community): Approve (continuous-integration) on 2015-04-09

Michi Henning (community): Approve on 2015-04-09

James Henstridge: Pending requested 2015-04-09

Diff: 1293 lines (+495/-331)

10 files modified

include/internal/artdownloader.h (+27/-8)
include/internal/lastfmdownloader.h (+30/-17)
include/internal/ubuntuserverdownloader.h (+27/-13)
include/thumbnailer.h (+30/-25)
src/lastfmdownloader.cpp (+58/-57)
src/thumbnailer.cpp (+208/-120)
src/ubuntuserverdownloader.cpp (+33/-28)
tests/download.cpp (+68/-53)
tools/lastfmtest.cpp (+8/-6)
tools/ubuntuservertest.cpp (+6/-4)

api

Superseded for merging into lp:thumbnailer

Michi Henning (community): Approve on 2015-04-01

PS Jenkins bot (community): Approve (continuous-integration) on 2015-03-31

James Henstridge: Pending requested 2015-03-27

Diff: 1293 lines (+495/-331)

10 files modified

include/internal/artdownloader.h (+27/-8)
include/internal/lastfmdownloader.h (+30/-17)
include/internal/ubuntuserverdownloader.h (+27/-13)
include/thumbnailer.h (+30/-25)
src/lastfmdownloader.cpp (+58/-57)
src/thumbnailer.cpp (+208/-120)
src/ubuntuserverdownloader.cpp (+33/-28)
tests/download.cpp (+68/-53)
tools/lastfmtest.cpp (+8/-6)
tools/ubuntuservertest.cpp (+6/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

124. By Xavi Garcia on 2015-03-31

Removed LastFmDownloader destructor implementation (which was empty) to use the default instead

123. By Xavi Garcia on 2015-03-31

Raw pointer removed to use unique_ptr instead. Some coding style changes

122. By Xavi Garcia on 2015-03-27

Modified ArtDownloader interface to return a std::string with the content of the image. Changed coding style to files using the ArtDownloader interface. Modified unit tests that used the ArtDownloader interface

121. By CI Train Bot Account on 2015-03-12

Releasing 1.3+15.04.20150312-0ubuntu1

120. By Albert Astals Cid on 2015-03-12

Use own QDBusConnection

Otherwise we're using the main one that has been created in the main thread and when doing blocking calls on it, it will block on the main thread instead of in the image provided thread as we want Fixes: #1410260
Approved by: Victor Thompson, Jussi Pakkanen, PS Jenkins bot, Michi Henning

119. By CI Train Bot Account on 2015-01-22

Releasing 1.3+15.04.20150122-0ubuntu1

118. By Florian Boucault on 2015-01-22

QML thumbnail provider: make sure sourceSize (aka requestedSize) is respected by downscaling at loading time if necessary. Makes TN_SIZE_ORIGINAL case much faster. Fixes: #1391368
Approved by: Jussi Pakkanen, PS Jenkins bot

117. By Florian Boucault on 2015-01-22

Keeps track of failed thumbnails and do not try to regenerate them. Fixes: #1389678
Approved by: Jussi Pakkanen, PS Jenkins bot

116. By CI Train Bot <${CITRAIN_USER}@canonical.com> on 2015-01-06

Releasing 1.3+15.04.20150106-0ubuntu1

115. By Jussi Pakkanen on 2015-01-06

Fix a few potential memory corruptions. Fixes: #1403906
Approved by: James Henstridge