Merge lp:~xavi-garcia-mena/keeper/keeper-errors-in-state-property into lp:keeper/devel

[Xavi Garcia]

This branch adds error notification in each keeper task.

This branch adds error notification in each keeper task.

The error is an enum located at the client headers.

I've also created a helper method in the client library that converts the enum from QDBusArgument to KeeperError (the final type).

As we return a QVariantMap in the state call it looks like Qt is not converting the type itself.
We should maybe return a own defined type and offer the user an interface to obtain the different values of the state.

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:131
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-ci/150/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1268
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1275
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1056
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1056/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1056
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1056/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1056
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1056/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1056
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1056/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1056
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1056/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1056
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1056/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-ci/150/rebuild

review: Approve (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:132
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-ci/151/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1269
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1276
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1057
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1057/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1057
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1057/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1057
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1057/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1057
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1057/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1057
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1057/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1057
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1057/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-ci/151/rebuild

review: Approve (continuous-integration)

[Charles Kerr (charlesk)]

Looks really good. As usual some minor suggestions, but less even of those than usual. Nice work.

review: Approve

[Xavi Garcia (xavi-garcia-mena)]

Thanks for the review, Charles.

I did all the suggested changes

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:133
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-ci/157/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1288
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1295
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1076
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1076/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1076
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1076/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1076
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1076/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1076
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1076/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1076
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1076/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1076
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1076/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-ci/157/rebuild

review: Approve (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-autoland/21/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1289/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1296
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1077
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1077/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1077
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1077/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1077/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1077
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1077/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1077
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1077/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1077
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1077/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/unity-api-1/job/lp-keeper-autoland/22/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1290/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1297
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1078
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1078/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1078
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1078/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1078
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1078/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1078
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1078/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1078
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1078/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1078/console

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

review: Approve (continuous-integration)

=== modified file 'include/client/client.h'
--- include/client/client.h	2016-12-05 11:36:32 +0000
+++ include/client/client.h	2016-12-21 08:37:30 +0000
@@ -19,6 +19,8 @@
 
 #pragma once
 
+#include "keeper-errors.h"
+
 #include <QObject>
 #include <QScopedPointer>
 #include <QStringList>
@@ -73,7 +75,7 @@
     void readyToBackupChanged();
     void backupBusyChanged();
 
-    void taskStatusChanged(QString const & displayName, QString const & status, double percentage);
+    void taskStatusChanged(QString const & displayName, QString const & status, double percentage, keeper::KeeperError error);
     void finished();
 
 private Q_SLOTS:

=== added file 'include/client/keeper-errors.h'
--- include/client/keeper-errors.h	1970-01-01 00:00:00 +0000
+++ include/client/keeper-errors.h	2016-12-21 08:37:30 +0000
@@ -0,0 +1,49 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3, as published
+ * by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranties of
+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+ * PURPOSE.  See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors:
+ *     Xavi Garcia Mena <[e-mail]>
+ */
+
+#pragma once
+
+#include <QDBusArgument>
+#include <QMetaType>
+
+namespace keeper
+{
+
+enum class KeeperError
+{
+    OK,
+    ERROR_UNKNOWN,
+    HELPER_READ_ERROR,
+    HELPER_WRITE_ERROR,
+    HELPER_INACTIVITY_DETECTED,
+    HELPER_SOCKET_ERROR,
+    HELPER_START_TIMEOUT,
+    NO_HELPER_INFORMATION_IN_REGISTRY,
+    HELPER_BAD_URL,
+    MANIFEST_STORAGE_ERROR,
+    COMMITTING_DATA_ERROR
+};
+
+KeeperError convertFromDBusVariant(const QVariant & value, bool *conversion_ok = nullptr);
+} // namespace keeper
+
+QDBusArgument &operator<<(QDBusArgument &argument, keeper::KeeperError value);
+const QDBusArgument &operator>>(const QDBusArgument &argument, keeper::KeeperError &val);
+
+Q_DECLARE_METATYPE(keeper::KeeperError)

=== modified file 'include/helper/helper.h'
--- include/helper/helper.h	2016-09-15 16:02:54 +0000
+++ include/helper/helper.h	2016-12-21 08:37:30 +0000
@@ -19,6 +19,7 @@
 
 #pragma once
 
+#include <client/keeper-errors.h>
 #include <util/attributes.h>
 
 #include <QObject>
@@ -69,6 +70,7 @@
 Q_SIGNALS:
     void state_changed(Helper::State);
     void percent_done_changed(float);
+    void error(keeper::KeeperError error);
 
 protected:
     Helper(QString const & appid, const clock_func& clock=default_clock, QObject *parent=nullptr);

=== modified file 'src/cli/command-line-client-view.cpp'
--- src/cli/command-line-client-view.cpp	2016-12-01 14:18:57 +0000
+++ src/cli/command-line-client-view.cpp	2016-12-21 08:37:30 +0000
@@ -48,7 +48,7 @@
 
 void CommandLineClientView::add_task(QString const & display_name, QString const & initial_status, double initial_percentage)
 {
-    tasks_strings_[display_name] = get_task_string(display_name, initial_status, initial_percentage);
+    tasks_strings_[display_name] = get_task_string(display_name, initial_status, initial_percentage, keeper::KeeperError::OK);
     // TODO see if we can do this in a better way
     // We add a line per each backup task
     std::cout << std::endl;
@@ -112,17 +112,62 @@
     return ret;
 }
 
-QString CommandLineClientView::get_task_string(QString const & displayName, QString const & status, double percentage)
-{
-
-    return QStringLiteral("%1    %2 %    %3").arg(displayName, 15).arg((percentage * 100), 10, 'f', 2, ' ').arg(status, -15);
-}
-
-void CommandLineClientView::on_task_state_changed(QString const & displayName, QString const & status, double percentage)
+QString CommandLineClientView::get_task_string(QString const & displayName, QString const & status, double percentage, keeper::KeeperError error)
+{
+
+    if (error == keeper::KeeperError::OK)
+        return QStringLiteral("%1    %2 %    %3").arg(displayName, 15).arg((percentage * 100), 10, 'f', 2, ' ').arg(status, -15);
+    else
+        return QStringLiteral("%1    %2 %    %3 %4").arg(displayName, 15).arg((percentage * 100), 10, 'f', 2, ' ').arg(status, -15).arg(get_error_string(error));
+}
+
+QString CommandLineClientView::get_error_string(keeper::KeeperError error)
+{
+    QString ret;
+    switch(error)
+    {
+        case keeper::KeeperError::ERROR_UNKNOWN:
+            ret = QStringLiteral("Unknown error");
+            break;
+        case keeper::KeeperError::HELPER_BAD_URL:
+            ret = QStringLiteral("Bad URL for keeper helper");
+            break;
+        case keeper::KeeperError::HELPER_INACTIVITY_DETECTED:
+            ret = QStringLiteral("Inactivity detected in task");
+            break;
+        case keeper::KeeperError::HELPER_START_TIMEOUT:
+            ret = QStringLiteral("Task failed to start");
+            break;
+        case keeper::KeeperError::HELPER_READ_ERROR:
+            ret = QStringLiteral("Read error");
+            break;
+        case keeper::KeeperError::HELPER_SOCKET_ERROR:
+            ret = QStringLiteral("Error creating internal socket");
+            break;
+        case keeper::KeeperError::HELPER_WRITE_ERROR:
+            ret = QStringLiteral("Write error");
+            break;
+        case keeper::KeeperError::MANIFEST_STORAGE_ERROR:
+            ret = QStringLiteral("Error storing manifest file");
+            break;
+        case keeper::KeeperError::NO_HELPER_INFORMATION_IN_REGISTRY:
+            ret = QStringLiteral("No helper information in registry");
+            break;
+        case keeper::KeeperError::OK:
+            ret = QStringLiteral("Success");
+            break;
+        case keeper::KeeperError::COMMITTING_DATA_ERROR:
+            ret = QStringLiteral("Error uploading data");
+            break;
+    }
+    return ret;
+}
+
+void CommandLineClientView::on_task_state_changed(QString const & displayName, QString const & status, double percentage, keeper::KeeperError error)
 {
     auto iter = tasks_strings_.find(displayName);
     if (iter != tasks_strings_.end())
     {
-        tasks_strings_[displayName] = get_task_string(displayName, status, percentage);
+        tasks_strings_[displayName] = get_task_string(displayName, status, percentage, error);
     }
 }

=== modified file 'src/cli/command-line-client-view.h'
--- src/cli/command-line-client-view.h	2016-11-30 14:46:29 +0000
+++ src/cli/command-line-client-view.h	2016-12-21 08:37:30 +0000
@@ -18,6 +18,8 @@
  */
 #pragma once
 
+#include <client/keeper-errors.h>
+
 #include <QMap>
 #include <QObject>
 #include <QTimer>
@@ -43,11 +45,12 @@
 
 public Q_SLOTS:
     void show_info();
-    void on_task_state_changed(QString const & displayName, QString const & status, double percentage);
+    void on_task_state_changed(QString const & displayName, QString const & status, double percentage, keeper::KeeperError error);
 
 private:
     char get_next_spin_char();
-    QString get_task_string(QString const & displayName, QString const & status, double percentage);
+    QString get_task_string(QString const & displayName, QString const & status, double percentage, keeper::KeeperError error);
+    QString get_error_string(keeper::KeeperError error);
 
     QString status_;
     QTimer timer_status_;

=== modified file 'src/client/CMakeLists.txt'
--- src/client/CMakeLists.txt	2016-11-30 14:46:29 +0000
+++ src/client/CMakeLists.txt	2016-12-21 08:37:30 +0000
@@ -1,8 +1,21 @@
 add_subdirectory(qml-plugin)
 
 set(
+  KEEPER_ERRORS_LIB
+  keeper-errors-lib
+)
+
+add_library(
+  ${KEEPER_ERRORS_LIB}
+  STATIC
+  keeper-errors.cpp
+  ${CMAKE_SOURCE_DIR}/include/client/keeper-errors.h
+)
+
+set(
   CLIENT_HEADERS
   ${CMAKE_SOURCE_DIR}/include/client/client.h
+  ${CMAKE_SOURCE_DIR}/include/client/keeper-errors.h
 )
 
 add_library(
@@ -18,6 +31,7 @@
 
 target_link_libraries(
   ${KEEPER_CLIENT_LIB}
+  ${KEEPER_ERRORS_LIB}
   qdbus-stubs
   Qt5::Core
   Qt5::DBus

=== modified file 'src/client/client.cpp'
--- src/client/client.cpp	2016-12-16 09:34:05 +0000
+++ src/client/client.cpp	2016-12-21 08:37:30 +0000
@@ -281,12 +281,20 @@
             double progress = state.value("percent-done").toDouble();
             auto status = state.value("action").toString();
 
+            keeper::KeeperError keeper_error = keeper::KeeperError::OK;
+            auto iter_error = state.find("error");
+            if (iter_error != state.end())
+            {
+                bool conversion_ok;
+                keeper_error = keeper::convertFromDBusVariant(state.value("error"), &conversion_ok);
+            }
+
             auto current_state = d->task_status[uuid];
             if (current_state.status != status || current_state.percentage < progress)
             {
                 d->task_status[uuid].status = status;
                 d->task_status[uuid].percentage = progress;
-                Q_EMIT(taskStatusChanged(state.value("display-name").toString(), status, progress));
+                Q_EMIT(taskStatusChanged(state.value("display-name").toString(), status, progress, keeper_error));
             }
         }
 

=== added file 'src/client/keeper-errors.cpp'
--- src/client/keeper-errors.cpp	1970-01-01 00:00:00 +0000
+++ src/client/keeper-errors.cpp	2016-12-21 08:37:30 +0000
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2016 Canonical, Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3, as published
+ * by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranties of
+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+ * PURPOSE.  See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors:
+ *     Xavi Garcia <[e-mail]>
+ */
+
+#include <client/keeper-errors.h>
+
+#include <QDebug>
+
+QDBusArgument &operator<<(QDBusArgument &argument, keeper::KeeperError value)
+{
+    argument.beginStructure();
+    argument << static_cast<int>(value);
+    argument.endStructure();
+    return argument;
+}
+
+const QDBusArgument &operator>>(const QDBusArgument &argument, keeper::KeeperError &val)
+{
+    int int_val;
+    argument.beginStructure();
+    argument >> int_val;
+    val = static_cast<keeper::KeeperError>(int_val);
+    argument.endStructure();
+    return argument;
+}
+
+namespace keeper
+{
+KeeperError convertFromDBusVariant(const QVariant & value, bool *conversion_ok)
+{
+    if (value.typeName() != QStringLiteral("QDBusArgument"))
+    {
+        qWarning() << Q_FUNC_INFO
+                   << " Error converting dbus QVariant to KeeperError, expected type is [ QDBusArgument ] and current type is: ["
+                   << value.typeName() << "]";
+        if (conversion_ok)
+            *conversion_ok = false;
+        return KeeperError(keeper::KeeperError::ERROR_UNKNOWN);
+    }
+    auto dbus_arg = value.value<QDBusArgument>();
+
+    if (dbus_arg.currentSignature() != "(i)")
+    {
+        qWarning() << Q_FUNC_INFO
+                   << " Error converting dbus QVariant to KeeperError, expected signature is \"(i)\" and current signature is: \""
+                   << dbus_arg.currentSignature() << "\"";
+        if (conversion_ok)
+            *conversion_ok = false;
+        return KeeperError(keeper::KeeperError::ERROR_UNKNOWN);
+    }
+    KeeperError ret;
+    dbus_arg >> ret;
+
+    if (conversion_ok)
+        *conversion_ok = true;
+
+    return ret;
+}
+}

=== modified file 'src/helper/backup-helper.cpp'
--- src/helper/backup-helper.cpp	2016-10-06 14:53:44 +0000
+++ src/helper/backup-helper.cpp	2016-12-21 08:37:30 +0000
@@ -62,8 +62,8 @@
         int rc = socketpair(AF_UNIX, SOCK_STREAM | SOCK_NONBLOCK, 0, fds);
         if (rc == -1)
         {
-            // TODO throw exception.
-            qWarning() << "BackupHelperPrivate: error creating socket pair to communicate with helper ";
+            qWarning() <<  QStringLiteral("Error creating socket to communicate with helper");;
+            Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_SOCKET_ERROR));
             return;
         }
 
@@ -140,7 +140,10 @@
                     std::function<void(bool)>{[this](bool success){
                         qDebug() << "Commit finished";
                         if (!success)
+                        {
                             write_error_ = true;
+                            Q_EMIT(q_ptr->error(keeper::KeeperError::COMMITTING_DATA_ERROR));
+                        }
                         else
                             uploader_committed_file_name_ = uploader_->file_name();
                         uploader_.reset();
@@ -175,6 +178,7 @@
     {
         stop_inactivity_timer();
         qWarning() << "Inactivity detected in the helper...stopping it";
+        Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_INACTIVITY_DETECTED));
         stop();
     }
 
@@ -212,6 +216,7 @@
                 }
                 else if (n < 0) {
                     read_error_ = true;
+                    Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_READ_ERROR));
                     stop();
                     return;
                 }
@@ -228,6 +233,7 @@
                 if (n < 0) {
                     write_error_ = true;
                     qWarning() << "Write error:" << socket->errorString();
+                    Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_WRITE_ERROR));
                     stop();
                 }
                 break;
@@ -258,6 +264,10 @@
         {
             if (!q_ptr->is_helper_running())
             {
+                if (n_uploaded_ > q_ptr->expected_size())
+                {
+                    Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_WRITE_ERROR));
+                }
                 q_ptr->set_state(Helper::State::FAILED);
             }
         }

=== modified file 'src/helper/helper.cpp'
--- src/helper/helper.cpp	2016-11-21 12:03:56 +0000
+++ src/helper/helper.cpp	2016-12-21 08:37:30 +0000
@@ -359,7 +359,8 @@
 
     void on_max_time_waiting_for_ual_started()
     {
-        qDebug() << "Max time reached waiting for UAL to start";
+        qWarning() << "Maximum time reached waiting for the helper to start.";
+        Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_START_TIMEOUT));
         q_ptr->set_state(Helper::State::FAILED);
         stop_wait_for_ual_timer();
     }

=== modified file 'src/helper/restore-helper.cpp'
--- src/helper/restore-helper.cpp	2016-12-05 11:36:32 +0000
+++ src/helper/restore-helper.cpp	2016-12-21 08:37:30 +0000
@@ -57,8 +57,8 @@
         int rc = socketpair(AF_UNIX, SOCK_STREAM | SOCK_NONBLOCK, 0, fds);
         if (rc == -1)
         {
-            // TODO throw exception.
-            qWarning() << "RestoreHelperPrivate: error creating socket pair to communicate with helper ";
+            qWarning() <<  QStringLiteral("Error creating socket to communicate with helper");;
+            Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_SOCKET_ERROR));
             return;
         }
 
@@ -167,6 +167,7 @@
     {
         stop_inactivity_timer();
         qWarning() << "Inactivity detected in the helper...stopping it";
+        Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_INACTIVITY_DETECTED));
         stop();
     }
 
@@ -207,6 +208,7 @@
                     else if (n < 0) {
                         read_error_ = true;
                         qDebug() << "Read error in restore helper: " << socket->errorString();
+                        Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_READ_ERROR));
                         stop();
                         return;
                     }
@@ -226,6 +228,7 @@
                     if (n < 0) {
                         write_error_ = true;
                         qWarning() << "Write error:" << write_socket_.errorString();
+                        Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_WRITE_ERROR));
                         stop();
                     }
                     break;
@@ -257,6 +260,10 @@
         {
             if (!q_ptr->is_helper_running())
             {
+                if (n_uploaded_ > q_ptr->expected_size())
+                {
+                    Q_EMIT(q_ptr->error(keeper::KeeperError::HELPER_WRITE_ERROR));
+                }
                 q_ptr->set_state(Helper::State::FAILED);
             }
         }

=== modified file 'src/qdbus-stubs/dbus-types.h'
--- src/qdbus-stubs/dbus-types.h	2016-11-30 14:46:29 +0000
+++ src/qdbus-stubs/dbus-types.h	2016-12-21 08:37:30 +0000
@@ -22,6 +22,7 @@
 #include <QtCore>
 #include <QString>
 #include <QVariantMap>
+#include <client/keeper-errors.h>
 
 typedef QMap<QString, QVariantMap> QVariantDictMap;
 Q_DECLARE_METATYPE(QVariantDictMap)
@@ -35,10 +36,11 @@
     {
         qRegisterMetaType<QVariantDictMap>("QVariantDictMap");
         qRegisterMetaType<QStringMap>("QStringMap");
+        qRegisterMetaType<keeper::KeeperError>("keeper::KeeperError");
 
         qDBusRegisterMetaType<QVariantDictMap>();
         qDBusRegisterMetaType<QStringMap>();
-//        Helper::registerMetaTypes();
+        qDBusRegisterMetaType<keeper::KeeperError>();
     }
 
     constexpr const char KEEPER_SERVICE[] = "com.canonical.keeper";

=== modified file 'src/service/CMakeLists.txt'
--- src/service/CMakeLists.txt	2016-11-11 14:50:06 +0000
+++ src/service/CMakeLists.txt	2016-12-21 08:37:30 +0000
@@ -49,6 +49,7 @@
   storage-framework
   util
   qdbus-stubs
+  keeper-errors-lib
 )
 
 target_link_libraries(

=== modified file 'src/service/keeper-task-backup.cpp'
--- src/service/keeper-task-backup.cpp	2016-11-08 09:03:09 +0000
+++ src/service/keeper-task-backup.cpp	2016-12-21 08:37:30 +0000
@@ -50,6 +50,7 @@
         qDebug() << "Initializing a backup helper";
         helper_.reset(new BackupHelper(DEKKO_APP_ID), [](Helper *h){h->deleteLater();});
         qDebug() << "Helper " <<  static_cast<void*>(helper_.data()) << " was created";
+        QObject::connect(helper_.data(), &Helper::error, [this](keeper::KeeperError error){ error_ = error;});
     }
 
     void ask_for_uploader(quint64 n_bytes, QString const & dir_name)

=== modified file 'src/service/keeper-task.cpp'
--- src/service/keeper-task.cpp	2016-11-08 09:03:09 +0000
+++ src/service/keeper-task.cpp	2016-12-21 08:37:30 +0000
@@ -35,6 +35,7 @@
     , task_data_(task_data)
     , helper_registry_(helper_registry)
     , storage_(storage)
+    , error_(keeper::KeeperError::OK)
 {
 }
 
@@ -49,8 +50,8 @@
     if (urls.isEmpty())
     {
         task_data_.action = helper_->to_string(Helper::State::FAILED);
-        task_data_.error = "no helper information in registry";
-        qWarning() << "ERROR: uuid: " << task_data_.metadata.uuid() << " has no url";
+        error_ = keeper::KeeperError::HELPER_BAD_URL;
+        qWarning() << QStringLiteral("Error: uuid %1 has no url").arg(task_data_.metadata.uuid());
         calculate_and_notify_state(Helper::State::FAILED);
         return false;
     }
@@ -65,6 +66,10 @@
         std::bind(&KeeperTaskPrivate::on_helper_percent_done_changed, this, std::placeholders::_1)
     );
 
+    QObject::connect(helper_.data(), &Helper::error, [this](keeper::KeeperError error){
+        error_ = error;
+    });
+
     helper_->start(urls);
     return true;
 }
@@ -132,8 +137,16 @@
     auto const percent_done = helper_->percent_done();
     ret.insert(QStringLiteral("percent-done"), double(percent_done));
 
+    qDebug() << "task_data_.action = " << task_data_.action;
     if (task_data_.action == "failed" || task_data_.action == "cancelled")
-        ret.insert(QStringLiteral("error"), task_data_.error);
+    {
+        auto error = error_;
+        if (task_data_.error != keeper::KeeperError::OK)
+        {
+            error = task_data_.error;
+        }
+        ret.insert(QStringLiteral("error"), qVariantFromValue(error));
+    }
 
     ret.insert(QStringLiteral("uuid"), uuid);
 
@@ -193,6 +206,11 @@
     }
 }
 
+keeper::KeeperError KeeperTaskPrivate::error() const
+{
+    return error_;
+}
+
 KeeperTask::KeeperTask(TaskData & task_data,
                        QSharedPointer<HelperRegistry> const & helper_registry,
                        QSharedPointer<StorageFrameworkClient> const & storage,
@@ -251,3 +269,10 @@
 
     return d->to_string(state);
 }
+
+keeper::KeeperError KeeperTask::error() const
+{
+    Q_D(const KeeperTask);
+
+    return d->error();
+}

=== modified file 'src/service/keeper-task.h'
--- src/service/keeper-task.h	2016-11-08 09:03:09 +0000
+++ src/service/keeper-task.h	2016-12-21 08:37:30 +0000
@@ -20,6 +20,7 @@
 
 #pragma once
 
+#include "client/keeper-errors.h"
 #include "helper/metadata.h"
 #include "helper/backup-helper.h"
 #include "helper/helper.h"
@@ -40,7 +41,7 @@
     struct TaskData
     {
         QString action;
-        QString error;
+        keeper::KeeperError error;
         Metadata metadata;
     };
 
@@ -61,6 +62,8 @@
     void cancel();
 
     QString to_string(Helper::State state);
+
+    keeper::KeeperError error() const;
 Q_SIGNALS:
     void task_state_changed(Helper::State state);
     void task_socket_ready(int socket_descriptor);

=== modified file 'src/service/private/keeper-task_p.h'
--- src/service/private/keeper-task_p.h	2016-11-08 09:03:09 +0000
+++ src/service/private/keeper-task_p.h	2016-12-21 08:37:30 +0000
@@ -41,6 +41,9 @@
     static QVariantMap get_initial_state(KeeperTask::TaskData const &td);
 
     QString to_string(Helper::State state);
+
+    keeper::KeeperError error() const;
+
 protected:
     void set_current_task_action(QString const& action);
     void on_helper_percent_done_changed(float percent_done);
@@ -57,4 +60,5 @@
     QSharedPointer<StorageFrameworkClient> storage_;
     QSharedPointer<Helper> helper_;
     QVariantMap state_;
+    keeper::KeeperError error_;
 };

=== modified file 'src/service/task-manager.cpp'
--- src/service/task-manager.cpp	2016-12-01 14:18:57 +0000
+++ src/service/task-manager.cpp	2016-12-21 08:37:30 +0000
@@ -147,6 +147,7 @@
                 auto& td = task_data_[uuid];
                 td.metadata = metadata;
                 td.action = QStringLiteral("queued"); // TODO i18n
+                td.error = keeper::KeeperError::OK;
                 set_initial_task_state(td);
             }
 
@@ -169,7 +170,7 @@
         }
         else
         {
-            td.error = "Error storing manifest file";
+            td.error = keeper::KeeperError::MANIFEST_STORAGE_ERROR;
             set_current_task_action(task_->to_string(Helper::State::FAILED));
         }
         active_manifest_.reset();

=== modified file 'tests/integration/helpers/helpers-test-failure.cpp'
--- tests/integration/helpers/helpers-test-failure.cpp	2016-09-29 13:49:14 +0000
+++ tests/integration/helpers/helpers-test-failure.cpp	2016-12-21 08:37:30 +0000
@@ -90,6 +90,13 @@
     // this one uses pooling so it should just call Get once
     EXPECT_TRUE(wait_for_all_tasks_have_action_state({user_folder_uuid}, "failed", user_iface));
 
+    QVariant error_value;
+    EXPECT_TRUE(get_task_property_now(user_folder_uuid, user_iface, "error", error_value));
+    bool conversion_ok;
+    auto keeper_error = keeper::convertFromDBusVariant(error_value, &conversion_ok);
+    EXPECT_TRUE(conversion_ok);
+    EXPECT_EQ(keeper_error, keeper::KeeperError::HELPER_WRITE_ERROR);
+
     // check that the content of the file is the expected
     EXPECT_EQ(0, StorageFrameworkLocalUtils::check_storage_framework_nb_files());
 

=== modified file 'tests/integration/helpers/helpers-test.cc'
--- tests/integration/helpers/helpers-test.cc	2016-11-22 09:37:40 +0000
+++ tests/integration/helpers/helpers-test.cc	2016-12-21 08:37:30 +0000
@@ -41,6 +41,7 @@
     BackupHelper helper("com.test.multiple_first_1.2.3");
 
     QSignalSpy spy(&helper, &BackupHelper::state_changed);
+    QSignalSpy spy_error(&helper, &Helper::error);
 
     helper.start({"/bin/ls","/tmp"});
 
@@ -53,6 +54,8 @@
     EXPECT_EQ(qvariant_cast<Helper::State>(arguments.at(0)), Helper::State::STARTED);
     arguments = spy.takeFirst();
     EXPECT_EQ(qvariant_cast<Helper::State>(arguments.at(0)), Helper::State::COMPLETE);
+
+    EXPECT_EQ(spy_error.count(), 0);
 }
 
 TEST_F(TestHelpers, StartFullTest)
@@ -300,15 +303,20 @@
     BackupHelper helper("com.bar_foo_8432.13.1");
 
     QSignalSpy spy(&helper, &BackupHelper::state_changed);
+    QSignalSpy spy_error(&helper, &Helper::error);
     QStringList urls;
     urls << "blah" << "/tmp";
     helper.start(urls);
 
     WAIT_FOR_SIGNALS(spy, 1, Helper::MAX_UAL_WAIT_TIME + 1000);
 
-    ASSERT_EQ(spy.count(), 1);
+    ASSERT_EQ(1, spy.count());
     QList<QVariant> arguments = spy.takeFirst();
-    EXPECT_EQ(qvariant_cast<Helper::State>(arguments.at(0)), Helper::State::FAILED);
+    EXPECT_EQ(Helper::State::FAILED, qvariant_cast<Helper::State>(arguments.at(0)));
+
+    ASSERT_EQ(1, spy_error.count());
+    arguments = spy_error.takeFirst();
+    EXPECT_EQ(keeper::KeeperError::HELPER_START_TIMEOUT, qvariant_cast<keeper::KeeperError>(arguments.at(0)));
 }
 
 TEST_F(TestHelpers, Inactivity)
@@ -319,6 +327,7 @@
     BackupHelper helper("com.bar_foo_8432.13.1");
 
     QSignalSpy spy(&helper, &BackupHelper::state_changed);
+    QSignalSpy spy_error(&helper, &Helper::error);
     QStringList urls;
     urls << TEST_INACTIVE_HELPER << "/tmp";
     helper.start(urls);
@@ -329,9 +338,13 @@
     // We can also check at the end for the state, which should be CANCELLED
     WAIT_FOR_SIGNALS(spy, 2, BackupHelper::MAX_INACTIVITY_TIME + 2000);
 
-    ASSERT_EQ(spy.count(), 2);
+    ASSERT_EQ(2, spy.count());
     QList<QVariant> arguments = spy.takeFirst();
     EXPECT_EQ(qvariant_cast<Helper::State>(arguments.at(0)), Helper::State::STARTED);
     arguments = spy.takeFirst();
     EXPECT_EQ(qvariant_cast<Helper::State>(arguments.at(0)), Helper::State::CANCELLED);
+
+    ASSERT_EQ(1, spy_error.count());
+    arguments = spy_error.takeFirst();
+    EXPECT_EQ(keeper::KeeperError::HELPER_INACTIVITY_DETECTED, qvariant_cast<keeper::KeeperError>(arguments.at(0)));
 }

=== modified file 'tests/integration/helpers/test-helpers-base.cpp'
--- tests/integration/helpers/test-helpers-base.cpp	2016-11-11 14:50:06 +0000
+++ tests/integration/helpers/test-helpers-base.cpp	2016-12-21 08:37:30 +0000
@@ -368,6 +368,7 @@
 void TestHelpersBase::SetUp()
 {
     Helper::registerMetaTypes();
+    DBusTypes::registerMetaTypes();
 
     g_setenv("XDG_DATA_DIRS", CMAKE_SOURCE_DIR, true);
     g_setenv("XDG_CACHE_HOME", CMAKE_SOURCE_DIR "/libertine-data", true);
@@ -440,6 +441,27 @@
     return finished;
 }
 
+bool TestHelpersBase::get_task_property_now(QString const & uuid, QSharedPointer<DBusInterfaceKeeperUser> const & keeper_user_iface, QString const & property, QVariant & value) const
+{
+    auto state = keeper_user_iface->state();
+    auto iter = state.find(uuid);
+    if (iter == state.end())
+    {
+        qWarning() << "Task " << uuid << " was not found in State";
+        return false;
+    }
+
+    auto iter_props = (*iter).find(property);
+    if (iter_props == (*iter).end())
+    {
+        qWarning() << "Property " << property << " was not found for task " << uuid;
+        return false;
+    }
+
+    value = (*iter_props);
+    return true;
+}
+
 bool TestHelpersBase::check_task_has_action_state(QVariantDictMap const & state, QString const & uuid, QString const & action_state)
 {
     auto iter = state.find(uuid);

=== modified file 'tests/integration/helpers/test-helpers-base.h'
--- tests/integration/helpers/test-helpers-base.h	2016-10-14 09:23:11 +0000
+++ tests/integration/helpers/test-helpers-base.h	2016-12-21 08:37:30 +0000
@@ -97,6 +97,8 @@
 
     bool check_task_has_action_state(QVariantDictMap const & state, QString const & uuid, QString const & action_state);
 
+    bool get_task_property_now(QString const & uuid, QSharedPointer<DBusInterfaceKeeperUser> const & keeper_user_iface, QString const & property, QVariant & value) const;
+
     bool capture_and_check_state_until_all_tasks_complete(QSignalSpy & spy, QStringList const & uuids, QString const & action_state, int max_timeout_msec = 15000);
 
     bool cancel_first_task_at_percentage(QSignalSpy & spy, double expected_percentage, QSharedPointer<DBusInterfaceKeeperUser> const & user_iface, int max_timeout_msec = 15000);

=== modified file 'tests/utils/CMakeLists.txt'
--- tests/utils/CMakeLists.txt	2016-09-29 13:49:14 +0000
+++ tests/utils/CMakeLists.txt	2016-12-21 08:37:30 +0000
@@ -19,6 +19,7 @@
 target_link_libraries(
   ${LIB_NAME}
   backup-helper
+  keeper-errors-lib
   util
   Qt5::Core
 )