Merge lp:~xapantu/noise/fix-1073187 into lp:~elementary-apps/noise/trunk

Proposed by xapantu
Status: Merged
Approved by: Raphael Isemann
Approved revision: 1658
Merged at revision: 1652
Proposed branch: lp:~xapantu/noise/fix-1073187
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 27 lines (+6/-6)
1 file modified
plugins/MPRIS/MPRIS.vala (+6/-6)
To merge this branch: bzr merge lp:~xapantu/noise/fix-1073187
Reviewer Review Type Date Requested Status
Raphael Isemann (community) functionality, code-style Approve
Review via email: mp+229869@code.launchpad.net

Commit message

Fix MPRIS-menu. It now correcty updates its visual appereance. Solution is maybe a bit hacky, we will see.

To post a comment you must log in.
lp:~xapantu/noise/fix-1073187 updated
1658. By xapantu

Code style

Revision history for this message
Raphael Isemann (teemperor) wrote :

Fixed codestyle and works now. It also seems to be no problem for other players (and i'm not aware of a string that should be send instead of null). => approve

Any (hopefully non-existing) problems with that are hopefully discovered in Beta1.

review: Approve (functionality, code-style)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/MPRIS/MPRIS.vala'
2--- plugins/MPRIS/MPRIS.vala 2014-04-19 22:03:29 +0000
3+++ plugins/MPRIS/MPRIS.vala 2014-08-06 21:22:11 +0000
4@@ -251,11 +251,11 @@
5 changed_properties = null;
6
7 try {
8- conn.emit_signal("org.mpris.MediaPlayer2.Noise",
9- "/org/mpris/MediaPlayer2",
10- "org.freedesktop.DBus.Properties",
11- "PropertiesChanged",
12- new Variant("(sa{sv}as)",
13+ conn.emit_signal (null,
14+ "/org/mpris/MediaPlayer2",
15+ "org.freedesktop.DBus.Properties",
16+ "PropertiesChanged",
17+ new Variant("(sa{sv}as)",
18 INTERFACE_NAME,
19 builder,
20 invalidated_builder)
21@@ -653,4 +653,4 @@
22 }
23 }
24
25-}
26\ No newline at end of file
27+}

Subscribers

People subscribed via source and target branches