Merge lp:~xanderfomin/pantheon-terminal/fix-1324577 into lp:~elementary-apps/pantheon-terminal/trunk
Proposed by
Alexander Fomin
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Sergey "Shnatsel" Davidoff | ||||
Proposed branch: | lp:~xanderfomin/pantheon-terminal/fix-1324577 | ||||
Merge into: | lp:~elementary-apps/pantheon-terminal/trunk | ||||
Diff against target: |
21 lines (+6/-2) 1 file modified
src/TerminalWidget.vala (+6/-2) |
||||
To merge this branch: | bzr merge lp:~xanderfomin/pantheon-terminal/fix-1324577 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
elementary Apps team | Pending | ||
Review via email:
|
Description of the change
There was a problem in process_argv() method for commands that consist from one string, because in the latter case (bin_path + " " + tmp[1]).split(" ") returns [bin_path, ""] array, but not [bin_path] which is expected.
To post a comment you must log in.
Unmerged revisions
- 577. By Alexander Fomin
-
Code style fixed
- 576. By Alexander Fomin
-
Command execution via "--execute" fixed
This indeed does fix the bug. Thanks!
However, the code written before you came around looks superfluous to me. Now that you've tracked down the cause of the bug, I'll see if I can rewrite it better.