Code review comment for lp:~xaav/loggerhead/export-tarball

Revision history for this message
Martin Pool (mbp) wrote :

[fix] You'll need to also remove this line:

  from bzrlib.export.tar_exporter import export_tarball

from since it's not used and doesn't exist.

I fixed the unbound local warning here:

When I run the tests for this (with those two fixes) I get a failure in your new test_download_tarball, because the response is

303 See Other
The resource has been moved to /;
you should be redirected automatically.

which makes it look like it's not actually matching the URL. Do you see this too?

« Back to merge proposal