Code review comment for lp:~xaav/loggerhead/export-tarball

Revision history for this message
xaav (xaav) wrote :

> [fix] You seem to be giving people uncompressed tarballs? .tgz is probably better. The default value to export_archive is unnecessary and probably just a distraction if it's called from only one place that does specify the value.

.tgz tarballs are not possible due to a bug in bzr. It is not within the scope of this patch to fix that bug.

> Were you able to get the tests to run and pass?

Yes. Everything passes.

> [fix] It looks like you want tarballs disabled by default (which I agree with), so it seems a bit strange to me that the keyword arguments default to true.

What line are you referring to?

« Back to merge proposal